Distance rates - Tax reclaimable portion shows too many decimals in system message

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.8-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): applausetester+ps309@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.3 / Chrome
App Component: Workspace Settings

Action Performed:

Precondition:

• Taxes feature is enabled.
• Distance rates feature is enabled.
• Track tax is enabled.

1. Go to staging.new.expensify.com
2. Go to workspace settings > Distance rates.
3. Click on any distance rate.
4. Click Tax rate.
5. Select a rate.
6. Click Tax reclaimable on.
7. Enter amount and save it.
8. Go to #admins.

Expected Result:

Tax reclaimable portion will not show too many decimals in system message.

Actual Result:

Tax reclaimable portion shows too many decimals in system message.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6760569_1741063243698.20250304_123727.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @johncschuster (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Tax reclaimable portion shows too many decimals in system message.

What is the root cause of that problem?

We are not specially handling POLICYCHANGELOG_UPDATE_CUSTOM_UNIT_RATE type report action to provide translations so we are displaying the reportAction.message the BE returns

What changes do you think we should make in order to solve the problem?

BE return action name is POLICYCHANGELOG_UPDATE_CUSTOM_UNIT_RATE

1. Create a new translation key for this action
2. Create a util function in ReportUtils like getUpgradeCustomUnitRateMessage and return translation and round the value of the tax reclaimable portion
3. Use this function in some places below like we did with other actions

• Add a case for this action here for the alternative text in LHN

• Add a case in ReportActionItem here for the action in ReportScreen

• Add a case in here for the copy message

• Handle the case in getReportNameInternal for chat thread header title here

Note: we have a similar feature here is update Tax reclaimable, and we need to add translation for this action too

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

NA

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[Krishna2323]

I have an open PR for adding translations for all the system messages. This will be fixed there.

[johncschuster]

Great! In that case, let's close this in favor of keeping that one open. Thanks, @Krishna2323!