[Due for payment 2025-03-21] [$250] Saved search - Deleting a saved search resets the currently opened search

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.8-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): applausetester+ps309@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.3 / Chrome
App Component: Search

Action Performed:

Precondition:

• There are at least two saved searches.

1. Go to staging.new.expensify.com
2. Go to Reports.
3. Open any saved search.
4. Click 3-dot menu on the other saved search.
5. Click Delete.
6. Delete the saved search.

Expected Result:

The currently opened search view will not be reset.

Actual Result:

The currently opened search view is reset after deleting a saved search.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6760807_1741091449367.20250304_202724.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021897254435294536283
• Upwork Job ID: 1897254435294536283
• Last Price Increase: 2025-03-05
• Automatic offers:
• nyomanjyotisa | Contributor | 106425080

Issue Owner

Current Issue Owner: @zanyrenney

[melvin-bot]

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

🚨 Edited by proposal-police: This proposal was edited at 2025-03-04 13:19:30 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Saved search - Deleting a saved search resets the currently opened search #57749

What is the root cause of that problem?

After deleting, we are clear advance filter and navigate to SEARCH_ROOT

App/src/hooks/useDeleteSavedSearch.tsx

Lines 22 to 28 in 734bc98

	clearAdvancedFilters();
	Navigation.navigate(
	ROUTES.SEARCH_ROOT.getRoute({
	query: buildCannedSearchQuery(),
	}),
	);
	};

What changes do you think we should make in order to solve the problem?

We will add a condition that if the saved search that is deleted is not the current saved search, we will not clear the filter and navigate anymore. We can use currentSearchHash from useSearchContext and compare with hashToDelete

App/src/hooks/useDeleteSavedSearch.tsx

Lines 22 to 28 in 734bc98

	clearAdvancedFilters();
	Navigation.navigate(
	ROUTES.SEARCH_ROOT.getRoute({
	query: buildCannedSearchQuery(),
	}),
	);
	};

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[nyomanjyotisa]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Saved search - Deleting a saved search resets the currently opened search

What is the root cause of that problem?

We always reset the currently opened search on delete saved search

App/src/hooks/useDeleteSavedSearch.tsx

Lines 19 to 28 in 734bc98

	const handleDelete = () => {
	deleteSavedSearch(hashToDelete);
	setIsDeleteModalVisible(false);
	clearAdvancedFilters();
	Navigation.navigate(
	ROUTES.SEARCH_ROOT.getRoute({
	query: buildCannedSearchQuery(),
	}),
	);
	};

What changes do you think we should make in order to solve the problem?

Only reset the currently opened search if currentSearchHash from useSearchContext is equal to hashToDelete

const {currentSearchHash} = useSearchContext();

    const handleDelete = () => {
        deleteSavedSearch(hashToDelete);
        setIsDeleteModalVisible(false);

        if(hashToDelete === currentSearchHash) {
            clearAdvancedFilters();
            Navigation.navigate(
                ROUTES.SEARCH_ROOT.getRoute({
                    query: buildCannedSearchQuery(),
                }),
            );
        }
    };

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

What alternative solutions did you explore? (Optional)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021897254435294536283

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)

[zanyrenney]

Adding the external label so we can get some movement here. @allroundexperts please could you take a look at the proposal above and let me know if we want to go forward with that one?

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The currently opened search view is reset after deleting a saved search.

What is the root cause of that problem?

We have two bugs

1. If we delete the saved search that isn't the viewing search, the currently opened search is reset

The RCA is that we always clear the filter and navigate to the default search

App/src/hooks/useDeleteSavedSearch.tsx

Lines 19 to 25 in c5bba74

	const handleDelete = () => {
	deleteSavedSearch(hashToDelete);
	setIsDeleteModalVisible(false);
	clearAdvancedFilters();
	Navigation.navigate(
	ROUTES.SEARCH_ROOT.getRoute({
	query: buildCannedSearchQuery(),

2. If we delete the current saved search, and click on the browser back button, we go back to the deleted saved search query

The RCA is that we use navigate when navigate to the default search then the delete saved search page still in the navigation stack

App/src/hooks/useDeleteSavedSearch.tsx

Lines 19 to 25 in c5bba74

	const handleDelete = () => {
	deleteSavedSearch(hashToDelete);
	setIsDeleteModalVisible(false);
	clearAdvancedFilters();
	Navigation.navigate(
	ROUTES.SEARCH_ROOT.getRoute({
	query: buildCannedSearchQuery(),

What changes do you think we should make in order to solve the problem?

1. We should check if the current opened search is the delete saved search, we shouldn't clear the filter and navigate to the default search

2. We should use goBack instead of navigate to remove the delete saved search page in the navigation stack

if (currentSearchHash === hashToDelete) {
    clearAdvancedFilters();
    Navigation.goBack(
        ROUTES.SEARCH_ROOT.getRoute({
            query: buildCannedSearchQuery(),
        }),
    );
}

App/src/hooks/useDeleteSavedSearch.tsx

Lines 19 to 25 in c5bba74

	const handleDelete = () => {
	deleteSavedSearch(hashToDelete);
	setIsDeleteModalVisible(false);
	clearAdvancedFilters();
	Navigation.navigate(
	ROUTES.SEARCH_ROOT.getRoute({
	query: buildCannedSearchQuery(),

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

This is the wrong logic in a hook, so don't need to test

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[allroundexperts]

Thanks for the proposals everyone.

@Themoonalsofall While your proposal has the correct RCA, you posted the correct solution (using currentSearchHash) only after @nyomanjyotisa's posted there proposal.

@nkdengineer Your proposal is same as what others posted earlier, with an additional bug that you pointed out.

As such, I think we should go with the first proposal that had the correct RCA and the solution. I suggest that we create a new issue for the second bug, and you can post your proposal there.

@nyomanjyotisa's proposal looks good to me.

🎀 👀 🎀 C+ reviewed