[Due for payment 2025-03-17][$250] iOS - TypeError: TaskQueue: Error with task : Cannot read property 'signupQualifier' of undefined

[Julesssss]

Problem

This crash has recently blown up on iOS --I don't see any crashes increasing on Android, though this could be the case.

We don't have reproducible steps

Fatal Exception: facebook::jsi::JSError
Exception in HostFunction: Unhandled JS Exception: TypeError: TaskQueue: Error with task : Cannot read property 'signupQualifier' of undefined

Stack Trace:
    at getOnboardingInitialPath (401791:32)
    at startOnboardingFlow         (401779:85)
    at anonymous                  (540755:66)
    at processNext                (70806:18)
    at _processUpdate             (70731:30)
    at anonymous                  (40510:22)

Solution:

Investigate stack trace

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021897037934087402019
• Upwork Job ID: 1897037934087402019
• Last Price Increase: 2025-03-04

Issue Owner

Current Issue Owner: @johncschuster

[Julesssss]

• Shared with expert contributors for triage
• Shared with deployers to figure out how this slipped through

[Shahidullah-Muffakir]

As mentioned in the Stack trace it is coming from here:

App/src/libs/actions/Welcome/OnboardingFlow.ts

Line 56 in bf1ac4a

const isVsb = onboardingValues.signupQualifier === CONST.ONBOARDING_SIGNUP_QUALIFIERS.VSB;

and

App/src/libs/actions/Welcome/OnboardingFlow.ts

Line 68 in bf1ac4a

const isIndividual = onboardingValues.signupQualifier === CONST.ONBOARDING_SIGNUP_QUALIFIERS.INDIVIDUAL;

Because null check is not added for signupQualifier.

like it is added here:

App/src/pages/OnboardingAccounting/BaseOnboardingAccounting.tsx

Line 60 in bf1ac4a

const isVsb = onboardingValues && 'signupQualifier' in onboardingValues && onboardingValues.signupQualifier === CONST.ONBOARDING_SIGNUP_QUALIFIERS.VSB;

[Julesssss]

Hey @Shahidullah-Muffakir, thanks would you like to be assigned to resolving this? We don't have reproducable steps for verification but it should be an easy to resolve and verify in the crash logs

[Shahidullah-Muffakir]

Hey @Shahidullah-Muffakir, thanks would you like to be assigned to resolving this? We don't have reproducable steps for verification but it should be an easy to resolve and verify in the crash logs

Sure, I can create a quick PR, the changes seems straight forward.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021897037934087402019

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Pujan92 (External)

[Julesssss]

Assigning @Shahidullah-Muffakir. For tests in the PR can you just add a couple of cases related to the onboarding flow. Something like:

• Create new account > company > set company size