[Due for payment 2025-04-23] Onboarding - Completed task does not show strikethrough style

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.11-4
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): sjodismosdjosdj@gmail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.3 / Chrome
App Component: Other

Action Performed:

1. Go to staging.new.expensify.com
2. Sign up with a new Gmail account.
3. Select "Manage my team's expenses" (important).
4. Select 1-10 employees.
5. Select any accounting software > Complete the onboarding.
6. Go to #admins.
7. Mark any task complete.

Expected Result:

The completed task will show strikethrough style (production behavior).

Actual Result:

The completed task does not show strikethrough style.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

View all open jobs on GitHub

Bug6768319_1741763533449.onboarding_task.mp4

Issue Owner

Current Issue Owner: @alexpensify

[melvin-bot]

Triggered auto assignment to @MariaHCD (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[Kalydosos]

🚨 Edited by proposal-police: This proposal was edited at 2025-03-12 10:27:00 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Onboarding - Completed task does not show strikethrough style

What is the root cause of that problem?

Some changes occured in PR #54165 have removed the completed task style from the code

const titleStyle = StyleUtils.getTaskPreviewTitleStyle(iconWrapperStyle.height, isTaskCompleted);

What changes do you think we should make in order to solve the problem?

We should consider the completion status of the task when rendering its style here from

App/src/components/ReportActionItem/TaskPreview.tsx

Line 130 in 7fdcb2c

<RenderHTML html={`<comment>${taskReport?.reportName ?? action?.childReportName ?? ''}</comment>`} />

to

<View style={[styles.alignSelfCenter, styles.flex1]}>
{isTaskCompleted && <RenderHTML html={<comment><s>${taskReport?.reportName ?? action?.childReportName ?? ''}</s></comment>} />}
{!isTaskCompleted && <RenderHTML html={<comment>${taskReport?.reportName ?? action?.childReportName ?? ''}</comment>} />}

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

[jjcoffee]

cc @Krishna2323 @mananjadhav