[HOLD Simplified Actions project][Change Policy] Reports - App returns to Inbox after changing expense workspace in Reports

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.13-0
Reproducible in staging?: Yes
Reproducible in production?: Unable to check
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp #57553
Email or phone of affected tester (no customers): applausetester+kok1@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.3 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

• Account has two workspaces.

1. Go to staging.new.expensify.com
2. Go to workspace chat.
3. Submit an expense.
4. Go to expense report.
5. Add /change-workspace to the end of the URL and send the link.
6. Go to Reports > Expense Reports.
7. Open the expense report in Step 4.
8. Click on the link in Step 5.
9. Select another workspace.

Expected Result:

App should stay in Reports page.

Actual Result:

App returns to Inbox after changing expense workspace in Reports.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6770369_1741932155761.20250314_135915.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @garrettmknight

[melvin-bot]

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @nkuoch (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[truph01]

Proposal

Please re-state the problem that we are trying to solve in this issue.

• App returns to Inbox after changing expense workspace in Reports.

What is the root cause of that problem?

• It comes from the new feature.
• In here, we didn't consider the case user are in report RHP screen, so it always open the report screen after changing policy.

What changes do you think we should make in order to solve the problem?

• We should add logic to handle that case:

    const {isInNarrowPaneModal} = useResponsiveLayout();
    const selectPolicy = useCallback(
        (policyID?: string) => {
            if (!policyID) {
                return;
            }
            if (isInNarrowPaneModal) {
                Navigation.navigate(ROUTES.SEARCH_REPORT.getRoute({reportID}));
            } else {
                Navigation.goBack(ROUTES.REPORT_WITH_ID.getRoute(reportID));
            }

            changeReportPolicy(reportID, policyID);
        },
        [reportID, isInNarrowPaneModal],
    );

• We can add the backTo param as well to make sure when clicking back button, the proper screen is opened.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

• Navigation logic, doesn't need a test.

What alternative solutions did you explore? (Optional)

• One alternative is using Navigation.goBack(ROUTES.SEARCH_REPORT.getRoute({reportID})) in the change above, which would pop the "Change Workspace" page from the navigation stack.