Skip to content

[Due for payment 2025-04-18] Make tooltips dismissible #58663

@puneetlath

Description

@puneetlath

Part of the Tooltips for new paid plan signups project

Main issue: #55872
Doc section: https://docs.google.com/document/d/1q5m1qGAmM_9CeT-y-EpPxJKZeNC6RAjrwzc13wq3X74/edit?tab=t.0#heading=h.44waz0wo5etg

Feature Description

Add an "x" for dismissing tooltips in product.

Manual Test Steps

  1. Make sure x's show on all tooltips
  2. Make sure clicking the x dismisses the tooltip without opening the UI element the tooltip is pointing to
  3. Make sure clicking on the UI element the tooltip is pointing to dismisses the tooltip
  4. Make sure clicking the tooltip body opens the UI element the tooltip is pointing to and dismisses the tooltip
  5. Make sure the tooltip stays dismissed in all scenarios when logging out and logging back in

Automated Tests

Frontend:

  • Update Tests in tests/ui/components/ProductTrainingContextProvider.tsx so it passes the updated structure for nvp_dismissProductTraining
  • Add a new test to check if the onyx value is populated correctly when clicking ‘x’ icon
  • Add a new test for admin tooltips to verify that it only shows for admin of at least one workspace
  • Add a new test to check these tooltips does not show for a migrated user.

Backend:

  • Update DismissProductTrainingTest to take into account the new data structure.
  • Verify storing the dismissal time separately, and the dismissedMethod.
Issue OwnerCurrent Issue Owner: @garrettmknight

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionWeeklyKSv2

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions