-
Notifications
You must be signed in to change notification settings - Fork 3.7k
Closed
Labels
Awaiting PaymentAuto-added when associated PR is deployed to productionAuto-added when associated PR is deployed to productionWeeklyKSv2KSv2
Description
Part of the Tooltips for new paid plan signups project
Main issue: #55872
Doc section: https://docs.google.com/document/d/1q5m1qGAmM_9CeT-y-EpPxJKZeNC6RAjrwzc13wq3X74/edit?tab=t.0#heading=h.44waz0wo5etg
Feature Description
Add an "x" for dismissing tooltips in product.
Manual Test Steps
- Make sure x's show on all tooltips
- Make sure clicking the x dismisses the tooltip without opening the UI element the tooltip is pointing to
- Make sure clicking on the UI element the tooltip is pointing to dismisses the tooltip
- Make sure clicking the tooltip body opens the UI element the tooltip is pointing to and dismisses the tooltip
- Make sure the tooltip stays dismissed in all scenarios when logging out and logging back in
Automated Tests
Frontend:
- Update Tests in
tests/ui/components/ProductTrainingContextProvider.tsxso it passes the updated structure for nvp_dismissProductTraining - Add a new test to check if the onyx value is populated correctly when clicking ‘x’ icon
- Add a new test for admin tooltips to verify that it only shows for admin of at least one workspace
- Add a new test to check these tooltips does not show for a migrated user.
Backend:
- Update
DismissProductTrainingTestto take into account the new data structure. - Verify storing the dismissal time separately, and the dismissedMethod.
Issue Owner
Current Issue Owner: @garrettmknightReactions are currently unavailable
Metadata
Metadata
Labels
Awaiting PaymentAuto-added when associated PR is deployed to productionAuto-added when associated PR is deployed to productionWeeklyKSv2KSv2