[$250] Request tax exempt status menu is WAY off in subscription

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.15-4
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @blimpich
Slack conversation (hyperlinked to channel name): #Expensify Bugs

Action Performed:

1. Signup for a new account
2. Create a Workspace
3. Navigate to Settings > Subscription
4. Click the three dot ellipsis menu in Subscription details

Expected Result:

Request tax exempt menu displayed right next to ellipsis menu

Actual Result:

Request tax exempt status menu is WAY off

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Screen.Recording.2025-03-18.at.3.00.10.PM.mov

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021902402582017323241
• Upwork Job ID: 1902402582017323241
• Last Price Increase: 2025-03-19

Issue Owner

Current Issue Owner: @rushatgabhane

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[m-natarajan]

proposal bt @shubham1206agra

Proposal

Please re-state the problem that we are trying to solve in this issue.

Request tax exempt status menu appears at bottom of the page

What is the root cause of that problem?

This issue stems from #56594

In the above mentioned PR, we have switched calculation of position of popover from per-click basis to initial layout basis.

In the subscription page, the three dot menu for Request tax exempt status is at the bottom of the page initially which caused the menu position to be fixed at the bottom of the page.

What changes do you think we should make in order to solve the problem?

To fix this issue, we need to first revert #56594 (atleast related to position calculation changes) so that we always calculate the position of popover on every click of the three dot button.

To fix #56505, we will use useLayoutEffect hook to calculate the initial popover position of the popover.

Example code -

useLayoutEffect(() => {
        calculateAndSetThreeDotsMenuPosition();
    }, [calculateAndSetThreeDotsMenuPosition]);

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

Not Required as this is a visual bug and cannot be replicated in tests.

What alternative solutions did you explore? (Optional)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021902402582017323241

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)

[bernhardoj]

This is already being handled in #57920

[Christinadobrzyn]

Thank you @bernhardoj - closing this in favor of #57011