[HOLD for payment 2025-05-06] [$250] Track-Track expenses use inconsistent currencies after changing payment currency

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: V9.1.17-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: N
Email or phone of affected tester (no customers): Slottwo1 fcvvbffd@gmail.com
Issue reported by: Applause Internal Team
Device used: Redminote 10s android 13
App Component: Money Requests

Action Performed:

1. Launch app
2. Login with a gmail account select track & manage expense
3. Tap settings > preferences > payment currency > select a different currency
4. Open self DM
5. Create a track manual, scan & distance expense

Expected Result:

Manual and scan expense created in self DM must reflect the same currency as in latest selected currency like track distance expense.

Actual Result:

Distance expense created in self DM reflect the same currency as in latest selected currency.

When payment currency set to a different currency, Track manual & scan expense is created in still shows the previously selected currency but track distance expense is created in latest selected currency.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6778951_1742783305786.Screenrecorder-2025-03-24-07-57-30-830.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021904896776849440639
• Upwork Job ID: 1904896776849440639
• Last Price Increase: 2025-03-26
• Automatic offers:
• dominictb | Reviewer | 106734354
• daledah | Contributor | 106734356

Issue Owner

Current Issue Owner: @daledah

Issue Owner

Current Issue Owner: @daledah

[melvin-bot]

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[daledah]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Distance expense created in self DM reflect the same currency as in latest selected currency.

What is the root cause of that problem?

When initializing data for a money request, the currency is determined from this line:

App/src/libs/actions/IOU.ts

Line 726 in 4750e38

const currency = policy?.outputCurrency ?? currentUserPersonalDetails?.localCurrencyCode ?? CONST.CURRENCY.USD;

For Track Expense, the policy is empty — causing the currency to default to currentUserPersonalDetails.localCurrencyCode.

However, in step 3, an action updates the outputCurrency of the personal policy. This results in the mismatch described in the original post, where the Track Expense currency doesn’t reflect the updated currency from step 3.

What changes do you think we should make in order to solve the problem?

In:

App/src/libs/actions/IOU.ts

Line 726 in 4750e38

const currency = policy?.outputCurrency ?? currentUserPersonalDetails?.localCurrencyCode ?? CONST.CURRENCY.USD;

we can fallback to the outputCurrency of the personal policy:

    const falbackPolicy = getPersonalPolicy();
    const currency = (policy ?? falbackPolicy)?.outputCurrency ?? currentUserPersonalDetails?.localCurrencyCode ?? CONST.CURRENCY.USD;

Same as what we did with distance request, it is why the bug is not appeared in tracking distance request:

App/src/pages/iou/request/step/IOURequestStepDistance.tsx

Line 153 in 4750e38

const policyCurrency = policy?.outputCurrency ?? getPersonalPolicy()?.outputCurrency ?? CONST.CURRENCY.USD;

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

Create a utility function to determine the request's currency.
Add test cases for key scenarios:

1. Track Expense
2. Create Expense in Workspace

What alternative solutions did you explore? (Optional)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021904896776849440639

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @dominictb (External)

[twisterdotcom]

58970.mp4

[dominictb]

@daledah Can you explain why this only happens with Manual & Scan but not Distance track expense?