[$250] Web -Thread - Two OpenReport requests when opening thread

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.21-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5857416
Email or phone of affected tester (no customers): applausetester+sdmsdsm19@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.3 / Chrome
App Component: Other

Action Performed:

1. Go to staging.new.expensify.com
2. [User A] Send a message to User B.
3. [User A] Right click on the message > Reply in thread.
4. [User A] Send a reply in thread.
5. [User B] Open chat with User A.
6. [User B] Open Network tab in developer tools.
7. [User B] Open the thread.

Expected Result:

There will be only one OpenReport request.

Actual Result:

There are two OpenReport requests when opening thread.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6788679_1743495558916.20250401_161606.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021909990107851342894
• Upwork Job ID: 1909990107851342894
• Last Price Increase: 2025-04-23
• Automatic offers:
• nkdengineer | Contributor | 107115000

Issue Owner

Current Issue Owner: @nkdengineer

[melvin-bot]

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

There are two OpenReport requests when opening thread.

What is the root cause of that problem?

The first OpenReport API is called here

App/src/pages/home/ReportScreen.tsx

Lines 505 to 508 in 8efc047

	fetchReport();
	// eslint-disable-next-line react-compiler/react-compiler, react-hooks/exhaustive-deps
	}, [route, isLinkedMessagePageReady, reportActionIDFromRoute]);

After that, the reportActions is not empty now, and this useEffect is triggered. It's the 2nd OpenReport

App/src/pages/home/ReportScreen.tsx

Lines 510 to 515 in 8efc047

	useEffect(() => {
	if (prevReportActions.length !== 0 || reportActions.length === 0) {
	return;
	}
	fetchReport();
	}, [prevReportActions, reportActions, fetchReport]);

What changes do you think we should make in order to solve the problem?

We can add reportMetadata.isLoadingInitialReportActions check here to prevent this can be triggered while another OpenReport is calling.

useEffect(() => {
    if (prevReportActions.length !== 0 || reportActions.length === 0 || reportMetadata.isLoadingInitialReportActions) {
        return;
    }
    fetchReport();
}, [prevReportActions, reportActions, fetchReport, reportMetadata.isLoadingInitialReportActions]);

App/src/pages/home/ReportScreen.tsx

Lines 510 to 515 in 8efc047

	useEffect(() => {
	if (prevReportActions.length !== 0 || reportActions.length === 0) {
	return;
	}
	fetchReport();
	}, [prevReportActions, reportActions, fetchReport]);

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

Result

Screen.Recording.2025-04-01.at.15.51.14.mov

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

@JmillsExpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

2 OpenReport requests when opening a new thread.

What is the root cause of that problem?

When we open a thread, if the childReportID doesn't exists, we trigger an open report to create a new optimistic thread.

App/src/libs/actions/Report.ts

Lines 1331 to 1338 in a099aa1

	if (!childReportID) {
	const participantLogins = PersonalDetailsUtils.getLoginsByAccountIDs(Object.keys(newChat.participants ?? {}).map(Number));
	openReport(newChat.reportID, '', participantLogins, newChat, parentReportAction.reportActionID);
	} else {
	Onyx.merge(`${ONYXKEYS.COLLECTION.REPORT}${childReportID}`, newChat);
	}
	Navigation.navigate(ROUTES.REPORT_WITH_ID.getRoute(newChat.reportID));

Then, when report screen is mounted, another open report is called.

App/src/pages/home/ReportScreen.tsx

Lines 501 to 507 in a099aa1

	useEffect(() => {
	// This function is triggered when a user clicks on a link to navigate to a report.
	// For each link click, we retrieve the report data again, even though it may already be cached.
	// There should be only one openReport execution per page start or navigating
	fetchReport();
	// eslint-disable-next-line react-compiler/react-compiler, react-hooks/exhaustive-deps
	}, [route, isLinkedMessagePageReady, reportActionIDFromRoute]);

Previously, we have a logic to skip it if it's an optimistic report (using shouldFetchReport, and there are other conditions to skip open report). But it was removed in #56819.

What changes do you think we should make in order to solve the problem?

I guess that some condition to skip the open report leads to the infinite loading because the app should call open report, but it's skipped. But in our case, when creating a new thread, we already calls the open report, so no need another open report when report screen is mounted. We can either add shouldFetchReport back, check only for reportMetadata.isOptimisticReport, or add a new field to reportMetadata to skip the open report. I prefer the 3rd one.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

We can render report screen and verify there is no open report when the report isOptimisticReport (or the new field) is true.

[melvin-bot]

@JmillsExpensify Still overdue 6 days?! Let's take care of this!

[melvin-bot]

@JmillsExpensify Still overdue 6 days?! Let's take care of this!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021909990107851342894