[Due for payment 2025-04-14] [$250] [Due for payment 2025-04-10] Reports - Total and action section fields are messed up

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.22-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5859741&group_by=cases:section_id&group_id=296775&group_order=asc
Email or phone of affected tester (no customers): applausetester+ccardfeed@applause.expensifail.com
Issue reported by: Applause - Internal Team

Action Performed:

1. Login as applausetester+ccardfeed@applause.expensifail.com
2. Navigate to Report Search
3. Take a look at Total and Action sections

Expected Result:

Total and Action sections should be clearly visible and inputs are not recognizable

Actual Result:

Total and action section fields are messed up

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6789125_1743528386712.Recording__5331.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021907766616372044683
• Upwork Job ID: 1907766616372044683
• Last Price Increase: 2025-04-03

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @RachCHopkins

[melvin-bot]

Triggered auto assignment to @tylerkaraszewski (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[daledah]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Total and action section fields are messed up

What is the root cause of that problem?

Comes from #58479
The translation text here:

App/src/languages/en.ts

Line 293 in c9387ae

review: (reviewParams?: ReviewParams) => `Review${reviewParams?.amount && ' '}${reviewParams?.amount}}`,

If reviewParams is undefined it will return Reviewundefinedundefined, because the logics typecast undefined to string.

Also it has a redundant } symbol, which is addressed in #59456

What changes do you think we should make in order to solve the problem?

Properly handle undefined in this case:

App/src/languages/en.ts

Line 293 in c9387ae

review: (reviewParams?: ReviewParams) => `Review${reviewParams?.amount && ' '}${reviewParams?.amount}}`,

review: (reviewParams?: ReviewParams) => `Review${reviewParams?.amount ? ` ${reviewParams?.amount}` : ''}`,

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

None

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[Guccio163]

1. This is not a deploy blocker - it's hidden under beta (cc: @mountiny)
2. This is not linked to Carousel component ([Due for payment 2025-04-10] [Better Expense Report View] Implement the Carousel component with tests #57507) but rather to MoneyRequest Reports View (Improve MoneyRequestReportView #58903)