[Due for payment 2025-04-28] [$250] Expense preview - Expense preview shows "Receiver > Payer" instead of "Payer > Receiver"

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.22-2
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: No, reproducible on hybrid only
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp #58479
Email or phone of affected tester (no customers): applausetester+sdsoidsj@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.3 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

• Log in with Expensifail account,

1. Go to staging.new.expensify.com
2. Go to 1:1 DM.
3. Click + > Pay user.
4. Enter amount > Next.
5. Click Pay elsewhere.

Expected Result:

The expense preview should show that "Payer > Receiver" (we can double confirm this iin Reports).

Actual Result:

The expense preview shows "Receiver > Payer" instead.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021907390149084405396
• Upwork Job ID: 1907390149084405396
• Last Price Increase: 2025-04-02

Issue Owner

Current Issue Owner: @zanyrenney

[melvin-bot]

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[zanyrenney]

adding external

[zanyrenney]

It is a minor UI adjustment, but if this is being stored or displayed incorrectly, we'll want a deeper investigation.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021907390149084405396

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)

[samranahm]

@jponikarchuk Just out of curiosity, do we really need to Login with Expensifail account? Is there some UIs limited to Expensifail accounts? cc @rushatgabhane

[ChavdaSachin]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Expense preview - Expense preview shows "Receiver > Payer" instead of "Payer > Receiver"

What is the root cause of that problem?

Small logical mistake during implementation here, managerID and ownerAccountID passed here are passed in reverse order.

App/src/libs/TransactionPreviewUtils.ts

Lines 54 to 55 in 9a58e7d

	const fromID = chooseIDBasedOnAmount(amount, managerID, ownerAccountID);
	const toID = chooseIDBasedOnAmount(amount, ownerAccountID, managerID);

What changes do you think we should make in order to solve the problem?

Change the order of managerID and ownerAccountID passed here.

App/src/libs/TransactionPreviewUtils.ts

Lines 54 to 55 in 9a58e7d

	const fromID = chooseIDBasedOnAmount(amount, managerID, ownerAccountID);
	const toID = chooseIDBasedOnAmount(amount, ownerAccountID, managerID);

    const fromID = chooseIDBasedOnAmount(amount, ownerAccountID, managerID);
    const toID = chooseIDBasedOnAmount(amount, managerID, ownerAccountID);

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

NA

What alternative solutions did you explore? (Optional)

Could be corrected by fixing the function body of chooseIDBasedOnAmount to work inversely, or any other small similar change.