[Due for payment 2025-04-18] Threads - 'Download as PDF" option is be shown for DM thread, room and workspace chat

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.25-0
Reproducible in staging?: Yes
Reproducible in production?: Unable to check, new feature
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): applausetester+sdsoidsj@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.3 / Chrome
App Component: Chat Report View

Action Performed:

Precondition:

• Log in with Expensifail account.

1. Go to staging.new.expensify.com
2. Go to 1:1 DM.
3. Send a message.
4. Right click on the message > Reply in thread.
5. Click on the thread header.

Expected Result:

'Download as PDF" option will not be shown for DM thread.

Actual Result:

'Download as PDF" option is be shown for DM thread.
When trying to download the PDF, it fails.

The download PDF option is also seen in room details page and workspace chat.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @RachCHopkins

[melvin-bot]

Triggered auto assignment to @RachCHopkins (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @mollfpr (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

'Download as PDF" option is be shown for DM thread.
When trying to download the PDF, it fails.

What is the root cause of that problem?

This comes from https://github.com/Expensify/App/pull/58084/files#diff-409b0e2fb439856e9897b808014031ce244a427d116ed30f37a2e0117599adc4L558

We removed the check caseID === CASES.MONEY_REPORT then the Download as PDF option is shown for all reports if the beta is enabled.

App/src/pages/ReportDetailsPage.tsx

Line 487 in 0754949

if (canUsePDFExport) {

What changes do you think we should make in order to solve the problem?

We should add the check the report is an expense report or not back

if (canUsePDFExport && caseID === CASES.MONEY_REPORT) {

App/src/pages/ReportDetailsPage.tsx

Line 487 in 0754949

if (canUsePDFExport) {

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.