[Due for payment 2025-05-14] [$250] Expense - No warning is shown when unapproving an expense that has been exported to QBO.

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.25-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail: #59195
Email or phone of affected tester (no customers): biruknew45+2vb92@gmail.com
Issue reported by: Applause Internal Team
Device used: Windows Windows 11 - Chrome, Samsung Galaxy A13 - Android 14, Wi-Fi, Chrome
App Component: Chat Report View

Action Performed:

Precondition -
Create a workspace
Enable QBO connection
Enable Auto-create entities

1. Go to https://staging.new.expensify.com/
2. Submit an expense
3. Approve the expense
4. Export to QBO
5. Try to unapprove the expense

Expected Result:

warning should read:
Heads up! This report has already been exported to Quickbooks Online. Changing it may lead to data discrepancies. Are you sure you want to unapprove this report?

Actual Result:

No warning appears

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6796896_1744186387988.bandicam_2025-04-09_11-05-51-992.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021909964435577717806
• Upwork Job ID: 1909964435577717806
• Last Price Increase: 2025-04-09
• Automatic offers:
• nkdengineer | Contributor | 107064801

Issue Owner

Current Issue Owner: @slafortune

[melvin-bot]

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @cristipaval (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[nkdengineer]

🚨 Edited by proposal-police: This proposal was edited at 2025-04-09 13:15:43 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

No warning appears

What is the root cause of that problem?

We missed the check report is exported or not here when moving the Unapprove option from ReportDetailsPage to MoneyReportHeader

App/src/components/MoneyReportHeader.tsx

Lines 587 to 599 in 9298e72

	[CONST.REPORT.SECONDARY_ACTIONS.UNAPPROVE]: {
	text: translate('iou.unapprove'),
	icon: Expensicons.CircularArrowBackwards,
	value: CONST.REPORT.SECONDARY_ACTIONS.UNAPPROVE,
	onSelected: () => {
	if (isDelegateAccessRestricted) {
	setIsNoDelegateAccessMenuVisible(true);
	return;
	}
	unapproveExpenseReport(moneyRequestReport);
	},
	},

What changes do you think we should make in order to solve the problem?

1. Move this modal from ReportDetailsPage to MoneyReportHeader

App/src/pages/ReportDetailsPage.tsx

Line 971 in 4c5750a

<ConfirmModal

2. Update the logic here like we did in ReportDetailsPage to show this modal

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.