[Due for payment 2025-04-18] [$250] Expense - Review button is disabled when "Prevent self-approvals" is enabled

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.25-1
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: No, reproducible on hybrid only
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): yonghongkok2+wanda@gmail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.3 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

• Log in with Gmail accounts.
• Create a new workspace with "Delay submissions" and "Add approvals" enabled.
• "Members must categorize all expenses" toggle is enabled in Categories settings.
• "Prevent self-approvals" is enabled in workspace settings > Rules.

1. Go to staging.new.expensify.com
2. Go to workspace chat.
3. Submit an expense without category to the workspace chat.
4. Click Review button.

Expected Result:

Review button should not be disabled because it opens expense report.

Actual Result:

Review button is disabled when "Prevent self-approvals" is enabled.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021909998695172883503
• Upwork Job ID: 1909998695172883503
• Last Price Increase: 2025-04-09
• Automatic offers:
• daledah | Contributor | 106853886

Issue Owner

Current Issue Owner: @sakluger

[melvin-bot]

Triggered auto assignment to @marcochavezf (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[melvin-bot]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[daledah]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Review button is disabled when "Prevent self-approvals" is enabled.

What is the root cause of that problem?

We disabled the review button here

App/src/components/ReportActionItem/ReportPreview.tsx

Lines 565 to 574 in 1390c29

	[CONST.REPORT.REPORT_PREVIEW_ACTIONS.REVIEW]: (
	<Button
	text={translate('common.review')}
	onPress={() => openReportFromPreview()}
	isDisabled={shouldDisableSubmitButton}
	icon={Expensicons.DotIndicator}
	iconFill={theme.danger}
	iconHoverFill={theme.dangerHover}
	/>
	),

What changes do you think we should make in order to solve the problem?

We should remove this isDisabled props because it opens expense report.

App/src/components/ReportActionItem/ReportPreview.tsx

Lines 565 to 574 in 1390c29

	[CONST.REPORT.REPORT_PREVIEW_ACTIONS.REVIEW]: (
	<Button
	text={translate('common.review')}
	onPress={() => openReportFromPreview()}
	isDisabled={shouldDisableSubmitButton}
	icon={Expensicons.DotIndicator}
	iconFill={theme.danger}
	iconHoverFill={theme.dangerHover}
	/>
	),

Also need to remove in View button

App/src/components/ReportActionItem/ReportPreview.tsx

Lines 575 to 582 in 1390c29

	[CONST.REPORT.REPORT_PREVIEW_ACTIONS.VIEW]: (
	<Button
	text={translate('common.view')}
	onPress={() => {
	openReportFromPreview();
	}}
	isDisabled={shouldDisableSubmitButton}
	/>

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[daledah]

@marcochavezf i can help to raise a quick PR if needed