[$250] [BACK BUTTON] Cards - In let's double check everything page, tapping device back button directs to cards page

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.26-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): Slottwo1 dooriya1@gmail.com
Issue reported by: Applause Internal Team
Device used: Redminote 10s android 13
App Component: Workspace Settings

Action Performed:

1. Go to https://staging.new.expensify.com/home
2. Go to workspace settings - company card
3. Add a american express direct feed card
4. Tap assign card
5. In assign card flow, in let's double check everything page tap app's top back button
6. In assign card flow, in let's double check everything page tap device back button

Expected Result:

In assign card flow, in let's double check everything page tap device back button / app's top back button must behave in consistent way.

Actual Result:

In assign card flow, in let's double check everything page tap device back button directs to card feed page but tapping app's back button directs to previous step.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021911679932027418691
• Upwork Job ID: 1911679932027418691
• Last Price Increase: 2025-04-14

Issue Owner

Current Issue Owner: @kadiealexander

[melvin-bot]

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021911679932027418691

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @getusha (External)

[M00rish]

🚨 Edited by proposal-police: This proposal was edited at 2025-04-16 17:11:38 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Cards - app back button and device back button behavior is not consistent

What is the root cause of that problem?

in the pages of assign card feed, there's no logic to handle device back button or browser back button to make it consistent with the app

What changes do you think we should make in order to solve the problem?

use the hook useHandleBackButton to deal device back button :

useHandleBackButton(() => {
        handleBackButtonPress();
        return true;
    });

I also noticed same problem happens in the previous step to this, when adding american express direct feed, which could be solved similarly.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

UI issue.

What alternative solutions did you explore? (Optional)

or alternatively update it to deal with both browser and device back buttons :

export default function useHandleBackButton(onBackPress: () => boolean) {
    const navigation = useNavigation();

    useFocusEffect(
        useCallback(() => {
            const hardwareBackSub = BackHandler.addEventListener(
                'hardwareBackPress',
                onBackPress
            );

            const unsubscribeBrowserBack = navigation.addListener('beforeRemove', (e) => {
                e.preventDefault(); 
                onBackPress();
            });

            return () => {
                hardwareBackSub.remove();
                unsubscribeBrowserBack();
            };
        }, [onBackPress, navigation])
    );
}

and use it in CardSelectionStep and all other pages for the assign card process:

const handleBackButtonPress = useCallback(() => {
        if (isEditing) {
            setAssignCardStepAndData({
                currentStep: CONST.COMPANY_CARD.STEP.CONFIRMATION,
                isEditing: false,
            });
            return;
        }
        setAssignCardStepAndData({currentStep: CONST.COMPANY_CARD.STEP.ASSIGNEE});
    },[isEditing]);

    useBackButtonHandler(handleBackButtonPress);