[Due for payment 2025-05-14] [$250] Hybrid- Copilot- fire animate appears on user B after user A removes copilot

[nlemma]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.1.26-2
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: No, reproducible on hybrid only
If this was caught during regression testing, add the test name, ID and link from TestRail: #58538
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Device used: Samsung Galaxy A25/Android 14
App Component: User Settings

Action Performed:

Precondition: User B is Full copilot of user A

1. Open app login with user B
2. User B switch to account of user A
3. At mweb, user A remove copilot access for User B
4. Observe app of user B
5. Tap Setting
6. Tap Profile

Expected Result:

User B will be signed out as copilot and signed in to original account

Actual Result:

User B sign out as copilot but fire animate is displayed. Tap on Setting/Profile, information of user B is blank for a time

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6796022_1744117701433.Az_Recorder_20250408_192021_1_.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021910444330811838758
• Upwork Job ID: 1910444330811838758
• Last Price Increase: 2025-04-17

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @sakluger / @strepanier03

[melvin-bot]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021910444330811838758

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

[acdtunes]

1. Bug Analysis and Root Cause

Observation:
When copilot access is removed from User B (while viewing User A’s account), the expected behavior is to sign User B out of the copilot session and revert to their original account. However, the actual result shows that although User B is indeed signed out, a “fire animate” (likely a loading or transition animation) erroneously persists. Additionally, tapping on Settings/Profile causes the UI to briefly render blank user information.

Probable Root Causes:
• State/Component Cleanup Failure: The animated element is likely not being terminated or unmounted properly when the copilot session is closed. This can happen if the component’s lifecycle methods (or corresponding React hooks) fail to cancel pending timers or animations during account switching.
• Asynchronous Data Fetch Issues: There might be an asynchronous call fetching user data for the previous (copilot) account that finishes after User B has been signed out, causing a state conflict or incorrect UI rendering.
• Race Conditions with Global State Management: Since Expensify’s app uses a unified front-end and state management system (likely Redux or React Context), the account-switch event may not be propagating immediately to all components, leaving some views temporarily in an inconsistent state.

⸻

2. Proposed Technical Approach

A. Enhance Component Lifecycle and Cleanup
• Identify Affected Components:
• The profile view and any component responsible for rendering the “fire animate” element.
• Components managing copilot status and account switching.
• Implement Proper Cleanup Using React Hooks:
• Add a dedicated useEffect hook in the affected components that monitors the user account state.
• Force Component Re-Mount on Account Switch:
• If needed, refactor navigation or state logic so that the account-switch event forces a full re-mount of key views (like Settings and Profile). This ensures the UI resets completely to reflect the active account’s data.

B. Improve Asynchronous Data Handling
• Cancel or Debounce Stale API Calls:
• Introduce cancellation tokens (or equivalent using an AbortController) to ensure that pending API calls for fetching profile data are canceled if the user’s account changes mid-request.
• Synchronize Global State:
• Ensure that the global state management layer propagates account changes promptly to every component subscribing to user data. This may involve tightening the synchronization between the copilot removal event and the state update that triggers UI re-rendering.

C. Remove or Condition the “Fire Animate” Element
• Conditional Rendering Based on State:
• Adjust the component logic that triggers the “fire animate” so that it only displays when it reflects a valid ongoing process.
• For example, if the animation is meant to show activity for a valid session change, add additional conditional checks that verify the user is indeed in a valid copilot session rather than in a transition state.

[melvin-bot]

📣 @acdtunes! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[acdtunes]

Contributor details
Your Expensify account email: acdtunes@gmail.com
Upwork Profile Link: (https://www.upwork.com/freelancers/~0136385688e1fdda13)