[Due for payment 2025-05-20] [$125] Company cards - Next button size in "Choose a card" page is smaller

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.29-4
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): applausetester+ccardfeed@applause.expensifail.com
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Log in to applausetester+ccardfeed@applause.expensifail.com
3. Go to workspace settings > Company cards
4. Select Visa cards feed
5. Click Assign card
6. Select a member
7. Click Next

Expected Result:

Next button size in "Choose a card" page will be the same as the Next button in Step 6

Actual Result:

Next button size in "Choose a card" page is smaller

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Platforms Tested:

On which of our officially supported platforms was this issue tested:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6805266_1744907528253.20250418_002912.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021913146804712993268
• Upwork Job ID: 1913146804712993268
• Last Price Increase: 2025-04-25
• Automatic offers:
• nkdengineer | Contributor | 107110836

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @lydiabarclay

[melvin-bot]

Triggered auto assignment to @lydiabarclay (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[nkdengineer]

🚨 Edited by proposal-police: This proposal was edited at 2025-04-17 16:49:45 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Next button size in "Choose a card" page is smaller

What is the root cause of that problem?

The button has more ph5 style here

App/src/pages/workspace/companyCards/assignCard/CardSelectionStep.tsx

Line 177 in 94ce13f

containerStyles={[styles.ph5, !shouldShowError && styles.mt5]}

While we already have this padding in the wrap view of InteractiveStepWrapper

App/src/pages/workspace/companyCards/assignCard/CardSelectionStep.tsx

Line 113 in 94ce13f

<InteractiveStepWrapper

App/src/components/InteractiveStepWrapper.tsx

Line 96 in 94ce13f

<View style={[styles.ph5, styles.mb5, styles.mt3, {height: CONST.BANK_ACCOUNT.STEPS_HEADER_HEIGHT}]}>

What changes do you think we should make in order to solve the problem?

Remove the ph5 style here. We can also remove mb5 style because this wrap View already have this style

App/src/pages/workspace/companyCards/assignCard/CardSelectionStep.tsx

Lines 177 to 179 in 94ce13f

	containerStyles={[styles.ph5, !shouldShowError && styles.mt5]}
	message={translate('common.error.pleaseSelectOne')}
	buttonStyles={styles.mb5}

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

UI bug

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[etCoderDysto]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Company cards - Next button size in "Choose a card" page is smaller

What is the root cause of that problem?

We are adding padding horizontal here

App/src/pages/workspace/companyCards/assignCard/CardSelectionStep.tsx

Line 177 in 94ce13f

containerStyles={[styles.ph5, !shouldShowError && styles.mt5]}

What changes do you think we should make in order to solve the problem?

Remove the padding horizontal

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A - UI issue

What alternative solutions did you explore? (Optional)

[github-actions]

⚠️ Thanks for your proposal. Please update it to follow the proposal template, as proposals are only reviewed if they follow that format (note the mandatory sections).

[abzokhattab]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Company cards - Next button size in "Choose a card" page is smaller

What is the root cause of that problem?

The issue occurs because we have a horizontal padding applied to the card selection and not the assignee

App/src/pages/workspace/companyCards/assignCard/CardSelectionStep.tsx

Line 173 in f7e0080

containerStyles={[styles.ph5, !shouldShowError && styles.mt5]}

App/src/pages/workspace/companyCards/assignCard/AssigneeStep.tsx

Line 199 in 157e986

containerStyles={[!shouldShowError && styles.mt5]}

The styles.ph5 rule adds 20 px of horizontal padding on each side (40 px total) to the button’s 100 %‑width container. Because the button stretches to fill that container, those 40 px are subtracted from its usable width, so it renders visibly narrower than the button in the previous step, which has no horizontal padding applied.

What changes do you think we should make in order to solve the problem?

we can either remove the padding styles.ph5 or add it to both container styles

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

NA

What alternative solutions did you explore? (Optional)

NA

[melvin-bot]

⚠️ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021913146804712993268

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ishpaul777 (External)