[Due for payment 2025-05-05] [$250] Expensify Card > Settings - App back button does not work

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.29-5
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): applausetester+k1k@applause.expensifail.com
Issue reported by: Applause - Internal Team

Action Performed:

1. Open Hybrid app
2. Sign in with a expensifail account
3. Tap on: Settings > Workspaces > Select any WS > > More features > Toggle on 'Expensify card' button
4. Go to Expensify card > Settings (If you are on v9.1.29-5 you've to add a bank account first)
5. Tap on back button within the app

Expected Result:

The user should redirected back to Expensify Card screen

Actual Result:

The button is not responsive

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Platforms Tested:

On which of our officially supported platforms was this issue tested:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6805303_1744909148414.az_recorder_20250417_131916.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021913032499959166010
• Upwork Job ID: 1913032499959166010
• Last Price Increase: 2025-04-18

Issue Owner

Current Issue Owner: @stephanieelliott

[melvin-bot]

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[samranahm]

🚨 Edited by proposal-police: This proposal was edited at 2025-04-17 18:32:29 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Expensify Card > Settings - App back button does not work

What is the root cause of that problem?

we are getting the lastRoute here and we are assuming that the last route in rootState.routes will always be WorkspaceSplitNavigator, that is not true here because RightModalNavigator is lastRoute

So this bug came from assuming .at(-1) is always Workspace navigator. But root routes are navigators, not individual screens.

App/src/libs/Navigation/helpers/goBackFromWorkspaceCentralScreen.ts

Lines 13 to 15 in 0591b9c

	const lastRoute = rootState.routes.at(-1);
	if (lastRoute?.name !== NAVIGATORS.WORKSPACE_SPLIT_NAVIGATOR) {

What changes do you think we should make in order to solve the problem?

We should get the workspaceRoute by finding in rootState this way ???

const workspaceRoute = rootState.routes.find(route => route.name === NAVIGATORS.WORKSPACE_SPLIT_NAVIGATOR);

This approach ensures that we're explicitly searching for the WorkspaceSplitNavigator within the root routes rather than assuming it's the last one in the array.

and update this to

if (!workspaceRoute) {
    Log.hmmm('[goBackFromWorkspaceCentralScreen] goBackFromWorkspaceCentralScreen was called from a different navigator than WorkspaceSplitNavigator.');
    return;
}

if (workspaceRoute.state?.routes && workspaceRoute.state.routes.length > 1) {
    Navigation.goBack(undefined, {shouldPopToTop: true});
    return;
}

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

Results

expensify.card.mp4

[FitseTLT]

🚨 Edited by proposal-police: This proposal was edited at 2025-04-17 19:40:32 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Expensify Card > Settings - App back button does not work

What is the root cause of that problem?

We are calling goBackFromWorkspaceCentralScreen on go back here

App/src/pages/workspace/expensifyCard/WorkspaceCardSettingsPage.tsx

Line 54 in 717b77a

onBackButtonPress={() => goBackFromWorkspaceCentralScreen(policyID)}

but the purpose of using goBackFromWorkspaceCentralScreen is to go back to previous WorkspaceSplitNavigator if it exists or go back to WorkspaceInitialPage when called from WorkspaceSplitNavigator. And it is supposed to be used from WorkspaceSplitNavigator screens and in here we are wrongly using it in non WorkspaceSplitNavigator so it will log error here and early return without any navigation

App/src/libs/Navigation/helpers/goBackFromWorkspaceCentralScreen.ts

Lines 15 to 18 in 717b77a

	if (lastRoute?.name !== NAVIGATORS.WORKSPACE_SPLIT_NAVIGATOR) {
	Log.hmmm('[goBackFromWorkspaceCentralScreen] goBackFromWorkspaceCentralScreen was called from a different navigator than WorkspaceSplitNavigator.');
	return;
	}

It was added in #59300 fo all WorkspaceSplitNavigator pages and the corresponding screen for the expensify card page should have been WorkspaceExpensifyCardPage but the pr wrongly added it to WorkspaceCardSettingsPage

What changes do you think we should make in order to solve the problem?

We should revert to the previous goback we were using so remove this and fallback to the previous default goBack

App/src/pages/workspace/expensifyCard/WorkspaceCardSettingsPage.tsx

Line 54 in 717b77a

onBackButtonPress={() => goBackFromWorkspaceCentralScreen(policyID)}

And for expensify card screen if needed the goBackFromWorkspaceCentralScreen should be add to WorkspaceCardSettingsPage
We should also remove if there are other places we used goBackFromWorkspaceCentralScreen in non-WorkspaceSplitNavigator

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N / A - navigation bug

What alternative solutions did you explore? (Optional)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021913032499959166010

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hoangzinh (External)

[WojtekBoman]

Hey, I can take care of it together with @borys3kk as I'm the author of the offending PR