[Due for payment 2025-05-20] [$250] Workspace - Bank address suggestion modal isn't showing

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.30-0
Reproducible in staging?: Yes
Reproducible in production?: Unable to check in Production, it asks to update the currency to USD.
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: #56931
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Device used: Windows 10 / Chrome, macOS Sequoia 15.3
App Component: Workspace Settings

Action Performed:

1. Navigate to https://staging.new.expensify.com/
2. Log in with a new Expensifail account
3. Create a workspace with "EUR" default currency
4. Navigate to Workspace settings - Workflows - Connect bank account - Connect manually
5. Select "Croatia" as the Country
6. Click on the "Confirm" button
7. Input any number or letters to the "Bank Address" field that would normally trigger an auto suggestion

Expected Result:

Bank address suggestion modal should be visible.

Actual Result:

Bank address suggestion modal isn't showing.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021917342205783621702
• Upwork Job ID: 1917342205783621702
• Last Price Increase: 2025-04-29

Issue Owner

Current Issue Owner: @adelekennedy

[melvin-bot]

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Bank address suggestion modal doesn't show.

What is the root cause of that problem?

We render all the field as a TextInput,

App/src/pages/ReimbursementAccount/NonUSD/BankInfo/subSteps/BankAccountDetails.tsx

Lines 79 to 91 in 7a42c6a

	return bankAccountDetailsFields?.map((field) => {
	if (field.valueSet !== undefined) {
	return getInputForValueSet(field, String(defaultValues[field.id as keyof typeof defaultValues]), isEditing, styles);
	}
	return (
	<View
	style={styles.mb6}
	key={field.id}
	>
	<InputWrapper
	InputComponent={TextInput}
	inputID={field.id}

It's the same with account holder details too.

What changes do you think we should make in order to solve the problem?

We can use the same approach as in BankInformation.

App/src/pages/settings/Wallet/InternationalDepositAccount/substeps/BankInformation.tsx

Lines 20 to 31 in 7a42c6a

	function getInputComponent(field: CorpayFormField) {
	if ((field.valueSet ?? []).length > 0) {
	return ValuePicker;
	}
	if (CONST.CORPAY_FIELDS.SPECIAL_LIST_REGION_KEYS.includes(field.id)) {
	return ValuePicker;
	}
	if (CONST.CORPAY_FIELDS.SPECIAL_LIST_ADDRESS_KEYS.includes(field.id)) {
	return AddressSearch;
	}
	return TextInput;
	}

First, create the getInputComponent function in both BankAccountDetails and AccountHolderDetails.

App/src/pages/ReimbursementAccount/NonUSD/BankInfo/subSteps/BankAccountDetails.tsx

Lines 89 to 97 in 7a42c6a

	<InputWrapper
	InputComponent={TextInput}
	inputID={field.id}
	label={field.label}
	aria-label={field.label}
	role={CONST.ROLE.PRESENTATION}
	shouldSaveDraft={!isEditing}
	defaultValue={String(defaultValues[field.id as keyof typeof defaultValues]) ?? ''}
	/>

Next, limit the address search to the selected country and map the id to the correct one.

For BankAccountDetails, we can get the country from reimbursementAccountDraft and map the input id as below.

limitSearchesToCountry={reimbursementAccountDraft?.['country']}
renamedInputKeys={{
    street: 'bankAddressLine1',
    city: 'bankCity',
}}

For AccountHolderDetails, we can get the country from defaultValues and map the input id as below.

limitSearchesToCountry={defaultValues['accountHolderCountry']}
renamedInputKeys={{
    street: 'accountHolderAddress1',
    city: 'accountHolderCity',
}}

(we can optionally map the other input to empty string)

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

[melvin-bot]

@adelekennedy Still overdue 6 days?! Let's take care of this!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021917342205783621702

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @thesahindia (External)