[$250] Android- BNP- Cursor in amount input field has different thickness before & after adding digit

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.31-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: No, reproducible on hybrid only
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): sdjsjndusdjsiudsd@gmail.com
Issue reported by: Applause Internal Team
Device used: Samsung Galaxy Z Fold 4 / Android 14
App Component: Money Requests

Action Performed:

1. Launch Expensify app.
2. Open FAB.
3. Tap Create expense.
4. Note the thickness of cursor in empty amount input field.
5. Enter a digit.
6. Note the thickness of cursor in amount input field when it's not empty.

Expected Result:

Cursor in amount input field will have the same thickness before & after adding digit (production behavior).
A similar issue was fixed here #57444.

Actual Result:

Cursor in amount input field has different thickness before & after adding digit.
It is thicker when the input is empty, thinner after adding a digit.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Screen_Recording_20250422_210559_Expensify.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021914705882095760459
• Upwork Job ID: 1914705882095760459
• Last Price Increase: 2025-05-06

Issue Owner

Current Issue Owner: @abdulrahuman5196

[melvin-bot]

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @carlosmiceli (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[samranahm]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Android- BNP- Cursor in amount input field has different thickness before & after adding digit

What is the root cause of that problem?

On some font variants (face/size) the width of the text content might be slightly wider than the calculated width of the text input when autoGrow enabled. if the text content wider, it will slightly hide the cursor.

App/src/components/TextInput/TextInputMeasurement/index.tsx

Lines 35 to 36 in a2b6087

	onSetTextInputWidth(e.nativeEvent.layout.width);
	onSetTextInputHeight(e.nativeEvent.layout.height);

What changes do you think we should make in order to solve the problem?

We should increase it by at least 2 pixels

onSetTextInputWidth(e.nativeEvent.layout.width + 2);

like we have added here

App/src/components/TextInput/TextInputMeasurement/index.tsx

Lines 69 to 80 in a2b6087

	onLayout={(e) => {
	if (e.nativeEvent.layout.width === 0 && e.nativeEvent.layout.height === 0) {
	return;
	}
	let additionalWidth = 0;
	if (isMobileSafari() || isSafari() || isMobileChrome()) {
	additionalWidth = 2;
	}
	onSetTextInputWidth(e.nativeEvent.layout.width + additionalWidth);
	onSetTextInputHeight(e.nativeEvent.layout.height);
	}}
	>

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.