[Due for payment 2025-06-02] [$250] Status - Status message is not saved when set for certain dates

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.32-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

Pre-condition: Use an account with no status message set

1. Go to https://staging.new.expensify.com/home
2. Tap account > status
3. Enter a message
4. Tap clear after > custom > date
5. Select next month and date 20
6. Tap save
7. Tap top arrow button
8. Tap save

Expected Result:

The status message should be saved correctly irrespective of the date selected

Actual Result:

Status message is not saved when set for certain dates

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Platforms Tested:

On which of our officially supported platforms was this issue tested:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6811078_1745444429241.Screenrecorder-2025-04-24-03-07-21-87.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021915710158435187205
• Upwork Job ID: 1915710158435187205
• Last Price Increase: 2025-05-02
• Automatic offers:
• brunovjk | Reviewer | 107188555
• mkzie2 | Contributor | 107188556

Issue Owner

Current Issue Owner: @garrettmknight

[melvin-bot]

Triggered auto assignment to @garrettmknight (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[mkzie2]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Status message is not saved when set for certain dates

What is the root cause of that problem?

We handle auto-clear status here

App/src/libs/Navigation/AppNavigator/AuthScreens.tsx

Lines 470 to 490 in e1e89c9

	useEffect(() => {
	if (!currentUserPersonalDetails.status?.clearAfter) {
	return;
	}
	const currentTime = new Date();
	const clearAfterTime = new Date(currentUserPersonalDetails.status.clearAfter);
	if (Number.isNaN(clearAfterTime.getTime())) {
	return;
	}
	const subMilisecondsTime = clearAfterTime.getTime() - currentTime.getTime();
	if (subMilisecondsTime > 0) {
	const timeoutID = setTimeout(() => {
	clearStatus();
	}, subMilisecondsTime);
	return () => {
	clearTimeout(timeoutID);
	};
	}
	clearStatus();
	}, [currentUserPersonalDetails.status?.clearAfter]);

In the case of this issue, the timeout value is over the max setTimeout value ( the max value is 2147483647 ref), the callback is called immediately

What changes do you think we should make in order to solve the problem?

If subMilisecondsTime value is larger than the max timeout value, we should create an setInterval to check the update instead of setTimeout. We can update logic during PR.

const MAX_SAFE_TIMEOUT = 2147483647;
        
if (subMilisecondsTime > 0) {
    let intervalId: NodeJS.Timeout | null = null;
    let timeoutId: NodeJS.Timeout | null = null;

    if (subMilisecondsTime > MAX_SAFE_TIMEOUT) {
        const checkInterval = 24 * 3600000; 
        intervalId = setInterval(() => {
            const now = new Date();
            const remainingTime = clearAfterTime.getTime() - now.getTime();
            
            if (remainingTime <= 0) {
                clearStatus();
                if (intervalId) {
                    clearInterval(intervalId);
                }
            } else if (remainingTime <= MAX_SAFE_TIMEOUT) {
                if (intervalId) {
                    clearInterval(intervalId);
                }
                timeoutId = setTimeout(() => {
                    clearStatus();
                }, remainingTime);
            }
        }, checkInterval);
    } else {
        timeoutId = setTimeout(() => {
            clearStatus();
        }, subMilisecondsTime);
        
    }
    
    return () => {
        if (intervalId) {
            clearInterval(intervalId);
        }
        if (timeoutId) {
            clearTimeout(timeoutId);
        }
    };
}

App/src/libs/Navigation/AppNavigator/AuthScreens.tsx

Lines 470 to 490 in e1e89c9

	useEffect(() => {
	if (!currentUserPersonalDetails.status?.clearAfter) {
	return;
	}
	const currentTime = new Date();
	const clearAfterTime = new Date(currentUserPersonalDetails.status.clearAfter);
	if (Number.isNaN(clearAfterTime.getTime())) {
	return;
	}
	const subMilisecondsTime = clearAfterTime.getTime() - currentTime.getTime();
	if (subMilisecondsTime > 0) {
	const timeoutID = setTimeout(() => {
	clearStatus();
	}, subMilisecondsTime);
	return () => {
	clearTimeout(timeoutID);
	};
	}
	clearStatus();
	}, [currentUserPersonalDetails.status?.clearAfter]);

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

This is a UI issue.

What alternative solutions did you explore? (Optional)

We can return early if subMilisecondsTime exceeds the limit

if (subMilisecondsTime > MAX_SAFE_TIMEOUT) {
   return;
}

App/src/libs/Navigation/AppNavigator/AuthScreens.tsx

Lines 470 to 490 in e1e89c9

	useEffect(() => {
	if (!currentUserPersonalDetails.status?.clearAfter) {
	return;
	}
	const currentTime = new Date();
	const clearAfterTime = new Date(currentUserPersonalDetails.status.clearAfter);
	if (Number.isNaN(clearAfterTime.getTime())) {
	return;
	}
	const subMilisecondsTime = clearAfterTime.getTime() - currentTime.getTime();
	if (subMilisecondsTime > 0) {
	const timeoutID = setTimeout(() => {
	clearStatus();
	}, subMilisecondsTime);
	return () => {
	clearTimeout(timeoutID);
	};
	}
	clearStatus();
	}, [currentUserPersonalDetails.status?.clearAfter]);

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021915710158435187205

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @brunovjk (External)

[Tony-MK]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Status message is not saved when set for certain dates

What is the root cause of that problem?

The setTimeout maximum delay is about 24.8 days, and the calculated subMilisecondsTime is greater than that.

Hence, clearStatus is called immediately.

App/src/libs/Navigation/AppNavigator/AuthScreens.tsx

Lines 480 to 487 in ee19279

	const subMilisecondsTime = clearAfterTime.getTime() - currentTime.getTime();
	if (subMilisecondsTime > 0) {
	const timeoutID = setTimeout(() => {
	clearStatus();
	}, subMilisecondsTime);
	return () => {
	clearTimeout(timeoutID);
	};

What changes do you think we should make in order to solve the problem?

We can set a date and time limit for the DatePicker and TimePicker, so that subMilisecondsTime does not surpass the maximum allowed delay.

App/src/pages/settings/Profile/CustomStatus/SetDatePage.tsx

Line 69 in ee19279

InputComponent={DatePicker}

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

We can create a setTimeout function that safely handles larger delays by creating new timeouts if there is some time remaining.

function safeSetTimeout(callback, delay) {
  const MAX_DELAY = 2147483647;

  if (delay <= MAX_DELAY) {
    return setTimeout(callback, delay);
  }

  // Otherwise, chain multiple timeouts
  const timeout = setTimeout(function tick() {
    const remaining = delay - MAX_DELAY;
    if (remaining > MAX_DELAY) {
      delay = remaining;
      setTimeout(tick, MAX_DELAY);
    } else {
      setTimeout(callback, remaining);
    }
  }, MAX_DELAY);

  return timeout;
}

[brunovjk]

Thanks for the proposals. Your RCAs make sense, but if we set the timeout for a few months ahead, according to your RCAs, it should also clear the status immediately, but that's not what happens in my tests:

Screen.Recording.2025-04-27.at.12.46.51.mov

@mkzie2 and @Tony-MK Can you reproduce it too? Did I miss something? Thank you very much.

Edit: Anyway, what do you think about creating an entry in Onyx to store the value of clearAfterTime or something, instead of using setTimeOut?

[Tony-MK]

Hey, @brunovjk, I also have reproduced the bug as you did.

Screen.Recording.2025-04-28.at.04.12.54.mov

It depends on the browser.

So, if the timeout is larger than 2147483647 in Chrome, it gives unexpected wait times.

As shown below, setting a delay of 2147483649, the timeout ends promptly, but with a delay of 9 billion ms, it behaves unexpectedly.

Screen.Recording.2025-04-28.at.04.29.10.mov

Since delay value only accepts a 32-bit int, it either overflows or modulos 2³², but is supposed to be clamped at 2147483647, reference

Edit: Anyway, what do you think about creating an entry in Onyx to store the value of clearAfterTime or something, instead of using setTimeOut?

Could you explain further?

What if the clearAfterTime will happen when the user is still on the profile page?

Then, without using setTimeout, I believe the status will not be cleared at the exact moment, but after a profile page re-render.