[Due for payment 2025-05-20] [$250] Onboarding - Onboarding tasks in #admins room are grayed out in offline mode

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.32-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): jsdijsojdsosjo@gmail.com
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Log in with a new Gmail account
3. Click Skip on Work email step
4. Select Manage my team's expenses
5. Select 1-10 employees
6. Select any accounting > Continue
7. Go to #admins
8. Send a message
9. Wait for a while
10. Go offline

Expected Result:

All the content in #admins room will not be grayed out in offline mode

Actual Result:

Onboarding tasks in #admins room are grayed out in offline mode

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Platforms Tested:

On which of our officially supported platforms was this issue tested:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6811727_1745505083449.20250424_222353.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021915751970400646068
• Upwork Job ID: 1915751970400646068
• Last Price Increase: 2025-04-25
• Automatic offers:
• Krishna2323 | Contributor | 107095230

Issue Owner

Current Issue Owner: @dylanexpensify

[melvin-bot]

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[nkdengineer]

🚨 Edited by proposal-police: This proposal was edited at 2025-04-24 14:59:33 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Onboarding tasks in #admins room are grayed out in offline mode

What is the root cause of that problem?

We don't update isOptimisticAction to false in successData for onboarding task action then the pendingAction is add here which causes the task action still be grayed out even when the API is done.

App/src/pages/home/report/PureReportActionItem.tsx

Lines 1401 to 1403 in 455570f

	pendingAction={
	draftMessage !== undefined ? undefined : action.pendingAction ?? (action.isOptimisticAction ? CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD : undefined)
	}

What changes do you think we should make in order to solve the problem?

We should update isOptimisticAction to false for task success data here. We can do the same for failure data if need.

App/src/libs/ReportUtils.ts

Line 9855 in d4e51d1

const tasksForSuccessData = tasksData.reduce<OnyxUpdate[]>((acc, {currentTask, taskCreatedAction, taskReportAction, completedTaskReportAction}) => {

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

Test completeOnboarding API and verify isOptimisticAction is updated to false after the API is success

What alternative solutions did you explore? (Optional)

We can remove action.isOptimisticAction ? CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD here since if the action has no pendingAction it means it's not an optimistic action anymore and shouldn't have offline feedback in this case.

App/src/pages/home/report/PureReportActionItem.tsx

Lines 1401 to 1403 in 455570f

	pendingAction={
	draftMessage !== undefined ? undefined : action.pendingAction ?? (action.isOptimisticAction ? CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD : undefined)
	}

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[Krishna2323]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Onboarding - Onboarding tasks in #admins room are grayed out in offline mode

What is the root cause of that problem?

• The isOptimisticAction for tasks, textComment and welcomeSignOffCommentAction is not set to null in the success data.
  

  App/src/libs/ReportUtils.ts

  Lines 9709 to 9718 in 19dbb47

  	const currentTask = buildOptimisticTaskReport(
  	actorAccountID,
  	targetChatReportID,
  	currentUserAccountID,
  	taskTitle,
  	taskDescription,
  	targetChatPolicyID,
  	CONST.REPORT.NOTIFICATION_PREFERENCE.HIDDEN,
  	task.mediaAttributes,
  	);

  
  

  App/src/libs/ReportUtils.ts

  Lines 9672 to 9673 in 19dbb47

  	const textComment = buildOptimisticAddCommentReportAction(message, undefined, actorAccountID, 1);
  	const textCommentAction: OptimisticAddCommentReportAction = textComment.reportAction;

  
  

  App/src/libs/ReportUtils.ts

  Lines 9745 to 9746 in 19dbb47

  	const welcomeSignOffComment = buildOptimisticAddCommentReportAction(welcomeSignOffText, undefined, actorAccountID, tasksData.length + 3);
  	const welcomeSignOffCommentAction: OptimisticAddCommentReportAction = welcomeSignOffComment.reportAction;

What changes do you think we should make in order to solve the problem?

• We need to add isOptimisticAction: null in the following places:
  

  App/src/libs/ReportUtils.ts

  Line 9862 in 19dbb47

  [taskReportAction.reportAction.reportActionID]: {pendingAction: null},

  
  

  App/src/libs/ReportUtils.ts

  Line 9888 in 19dbb47

  [taskCreatedAction.reportActionID]: {pendingAction: null},

  
  

  App/src/libs/ReportUtils.ts

  Line 9898 in 19dbb47

  [completedTaskReportAction.reportActionID]: {pendingAction: null},

  
  

  App/src/libs/ReportUtils.ts

  Line 9956 in 19dbb47

  [textCommentAction.reportActionID]: {pendingAction: null},

  
  

  App/src/libs/ReportUtils.ts

  Lines 10120 to 10121 in 19dbb47

  	[createdAction.reportActionID]: {
  	pendingAction: null,

  
  

  App/src/libs/ReportUtils.ts

  Line 10144 in 19dbb47

  [welcomeSignOffCommentAction.reportActionID]: {pendingAction: null},

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

We can test the completeOnboarding api and verify that the message are not greyed out on api success

What alternative solutions did you explore? (Optional)

N/A

Result

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021915751970400646068

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @jayeshmangwani (External)

[Krishna2323]

PROPOSAL UPDATED

• Added one more reference where we need to add isOptimisticAction: null and fixed a typo.

[jayeshmangwani]

@Krishna2323 's proposal looks good to me. I agree that onboarding company size message and the welcomeSignOffTitleManageTeam should also not be greyed out when offline, along with the tasks.

🎀 👀 🎀 C+ reviewed