[$250] Expense - Unhold option is available for user who does not hold the expense which causes error

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.32-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

Precondition:

• Log in with Expensifail account

1. Go to staging.new.expensify.com
2. [User A] Submit two expenses to User B
3. [User A] Go to expense report
4. [User A] Select one of the expenses via checkbox
5. [User A] Click on the dropdown > Hold
6. [User A] Enter a reason and save it
7. [User B] Open chat with User A
8. [User B] Go to expense report
9. [User B] Click on the held expense, then click on the report header
10. [User B} Note that there is no Unhold option because only the person who holds the expense can unhold it in p2p expense
11. [User B] Close the RHP
12. [User B].Select the held expense via checkbox
13. [User B] Click on the dropdown > Unhold
14. [User B] Close the RHP and click on the expense which is now unheld
15. [User B] Note that it throws error "Unexpected error taking this expense off hold. Please try again later."

Expected Result:

In Step 13, the receiver should not have the option to unhold the expense because only the person who holds the expense can unhold it in p2p expense

Actual Result:

In Step 13, the receiver is given the option to unhold the expense when they are not the one who holds the expense
In Step 15, when the receiver unholds the expense, it throws error "Unexpected error taking this expense off hold. Please try again later."

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Platforms Tested:

On which of our officially supported platforms was this issue tested:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6811753_1745506943148.20250424_225148.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021915823501257164210
• Upwork Job ID: 1915823501257164210
• Last Price Increase: 2025-05-02

Issue Owner

Current Issue Owner: @Ollyws

[melvin-bot]

Triggered auto assignment to @OfstadC (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[bernhardoj]

🚨 Edited by proposal-police: This proposal was edited at 2025-04-24 16:37:40 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Unhold option is available for the user that doesn't do the hold when selecting from checkbox.

What is the root cause of that problem?

Currently, we show the UNHOLD option without checking who hold it, or whether the user can UNHOLD it or not. We only check if it's currently on hold.

App/src/hooks/useSelectedTransactionsActions.ts

Lines 48 to 52 in f020d19

	if (allTransactionOnHold && selectedTransactions.length === 1) {
	options.push({
	text: translate('iou.unhold'),
	icon: Expensicons.Stopwatch,
	value: UNHOLD,

What changes do you think we should make in order to solve the problem?

We need to follow the same approach in report details page by checking if the user can unhold or not using canHoldUnholdReportAction util.

App/src/pages/ReportDetailsPage.tsx

Line 781 in f020d19

const canHoldUnholdReportAction = canHoldUnholdReportActionUtil(moneyRequestAction);

We only need to get the first transactionID since we only allow to hold/unhold a single expense.

const action = getIOUActionForTransactionID(reportActions, selectedTransactionsID.at(0) ?? '');
const {canHoldRequest, canUnholdRequest} = canHoldUnholdReportAction(action);

if (allTransactionOnHold && selectedTransactions.length === 1 && canUnholdRequest) {
    ...
}

We can apply the same to HOLD option if needed.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

Test useSelectedTransactionsActions hook and verify it returns the correct options.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021915823501257164210

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws (External)

[Tony-MK]

Should be fixed by #60436.

[Nick4dawin]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Unhold option is available for the user that doesn't do the hold when selecting from checkbox.

What is the root cause of that problem?

Currently, we show the UNHOLD option without checking who hold it, or whether the user can UNHOLD it or not. We only check if it's currently on hold.

App/src/hooks/useSelectedTransactionsActions.ts
Lines 48 to 52 in f020d19

if (allTransactionOnHold && selectedTransactions.length === 1) { 
    options.push({ 
        text: translate('iou.unhold'), 
        icon: Expensicons.Stopwatch, 
        value: UNHOLD, 

What changes do you think we should make in order to solve the problem?

We need to follow the same approach in report details page by checking if the user can unhold or not using canHoldUnholdReportActionUtil.

First, we need to import the utility:

import {canDeleteCardTransactionByLiabilityType, canDeleteTransaction, canHoldUnholdReportAction as canHoldUnholdReportActionUtil} from '@libs/ReportUtils';

Then we need to modify the code to check permissions before showing the unhold option:

if (allTransactionOnHold && selectedTransactions.length === 1) {
    // Get the action for the selected transaction
    const action = getIOUActionForTransactionID(reportActions, selectedTransactionsID[0]);
    
    // Check if this user can unhold the expense using the utility function
    const {canUnholdRequest} = canHoldUnholdReportActionUtil(action);
    
    // Only add the unhold option if the user has permission to unhold
    if (canUnholdRequest) {
        options.push({
            text: translate('iou.unhold'),
            icon: Expensicons.Stopwatch,
            value: UNHOLD,
            onSelected: () => {
                // ... existing code ...
            },
        });
    }
}

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

Test useSelectedTransactionsActions hook and verify it returns the correct options.