[Due for payment 2025-06-02] [$250] Invoice- Amount in invoice thread header is not the same as invoice amount when edited offline

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.33-3
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: No, reproducible on hybrid only
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): applausetester+290404kh@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.3 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

• Invoice feature is enabled.

1. Go to staging.new.expensify.com
2. Go offline.
3. Go to FAB > Send invoice.
4. Enter amount > Next.
5. Select any user > Next.
6. Click Send invoice.
7. Go to invoice thread.
8. Click Amount.
9. Edit the amount and save it.

Expected Result:

The new amount in invoice thread header will match the edited amount.

Actual Result:

The new amount in invoice thread header is not the same as the edited amount when edited offline.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021917347146786979910
• Upwork Job ID: 1917347146786979910
• Last Price Increase: 2025-04-29
• Automatic offers:
• mkzie2 | Contributor | 107137054

Issue Owner

Current Issue Owner: @mkzie2

[melvin-bot]

Triggered auto assignment to @lydiabarclay (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[mkzie2]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The new amount in invoice thread header is not the same as the edited amount when edited offline.

What is the root cause of that problem?

The invoice report's total and transaction amount should be negative (compared to BE final response) but they are optimistically positive. Leading to the total calculation logic here to be incorrect:

App/src/libs/actions/IOU.ts

Lines 3842 to 3847 in 59cb784

	} else if ((isExpenseReport(iouReport) || isInvoiceReportReportUtils(iouReport)) && !Number.isNaN(iouReport.total) && iouReport.total !== undefined) {
	// For expense report, the amount is negative, so we should subtract total from diff
	updatedMoneyRequestReport = {
	...iouReport,
	total: iouReport.total - diff,
	};

So for example, the previous total is 100, the updated one is 200, so the diff is 100, and by the above logic, the calculated updated total is 100 - 100 = 0. The previous total should have been negative as the comment in the above snippet suggested.

What changes do you think we should make in order to solve the problem?

Update buildOptimisticInvoiceReport here and buildOptimisticTransaction in getSendInvoiceInformation here to build with negative amounts.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

NA

What alternative solutions did you explore? (Optional)

Update the IOUTest's sendInvoice test case here to include update amount with same currency case.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021917347146786979910

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hoangzinh (External)

[hoangzinh]

@mkzie2's proposal looks good to me.

Link to proposal #61050 (comment)

🎀👀🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @luacmartins, see https://stackoverflow.com/c/expensify/questions/7972 for more details.