[Due for payment 2025-05-22] [Better Expense Report View] - Expense with multiple violations does not show Review Required when held

[nlemma]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.40-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: #60819
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Device used: Windows 10 / Chrome, Samsung Galaxy A12 / Android 13
App Component: Chat Report View

Action Performed:

1. Log in to staging.expensify.com
2. Create an expense with multiple violations (Duplicate, amount over the limit, no receipt, no categories)
3. Put the created expense on Hold
4. Go to Expense Preview

Expected Result:

"Review Required" RBR is displayed on expense with multiple violations

Actual Result:

"Expense is put on hold" is displayed when an expense with multiple violations is put on hold

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6823013_1746526656448.Recording__329.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @trjExpensify

[melvin-bot]

Triggered auto assignment to @miljakljajic (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[nkdengineer]

🚨 Edited by proposal-police: This proposal was edited at 2025-05-06 11:15:36 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

"Expense is put on hold" is displayed when an expense with multiple violations is put on hold

What is the root cause of that problem?

We are prioritizing showing 'iou.expenseWasPutOnHold' here

App/src/libs/TransactionPreviewUtils.ts

Lines 177 to 179 in eda8408

	if (shouldShowHoldMessage && RBRMessage === undefined) {
	RBRMessage = {translationPath: 'iou.expenseWasPutOnHold'};
	}

What changes do you think we should make in order to solve the problem?

We should move this code to the below here

App/src/libs/TransactionPreviewUtils.ts

Lines 185 to 195 in eda8408

	if (hasFieldErrors && RBRMessage === undefined) {
	const merchantMissing = isMerchantMissing(transaction);
	const amountMissing = isAmountMissing(transaction);
	if (amountMissing && merchantMissing) {
	RBRMessage = {translationPath: 'violations.reviewRequired'};
	} else if (amountMissing) {
	RBRMessage = {translationPath: 'iou.missingAmount'};
	} else if (merchantMissing) {
	RBRMessage = {translationPath: 'iou.missingMerchant'};
	}
	}

Note: We should also consider the priority of iou.missingAmount and iou.missingMerchant to sort

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

NA

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[trjExpensify]

Bug fix from this PR, @JakubKorytko is going to handle.