-
Notifications
You must be signed in to change notification settings - Fork 3.7k
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Issue reported by: @joekaufmanexpensify
Slack conversation (hyperlinked to channel name): #convert
Action Performed:
Precondition: reproduction requires using ad-hoc build from #56838
- As user 1 create a workspace.
- As user 2 submit another IOU to user 1.
- As user 1, click Pay and then Pay with %workspace name% workspace. This moves the IOU to the workspace via the bottom up flow.
Expected Result:
We use the same system messages in the 1:1 DM and expense report when moving an IOU to an existing workspace for the bottom-up flow with the new MoveIOUReportToExistingPolicy command as we do with the existing CreateWorkspaceFromIOUPayment command. We should also use the same system message in both places for the MoveIOUReportToPolicyAndInviteSubmitter command. This means using the following system message:
moved this report to the [%workspace name%](link to submitter workspace chat) workspace
Actual Result:
The MoveIOUReportToExistingPolicy doesn't use the correct system messages in the 1:1 DM or expense report. We need to update it to accept a new param and generate a moved action to the DM just like CreateWorkspaceFromIOUPayment
Workaround:
N/A
Platforms:
Select the officially supported platforms where the issue was reproduced:
- MacOS: Chrome / Safari
Screenshots/Videos
Issue Owner
Current Issue Owner: @joekaufmanexpensifyMetadata
Metadata
Assignees
Labels
Type
Projects
Status