[$250] [AU] - LHN - Thread title changes not displayed until we reload the page

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: v9.1.44-4
Reproducible in staging?: Yes
Reproducible in production?: Yes
Expensify/Expensify Issue URL: https://expensify.testrail.io/index.php?/cases/view/2654654
Issue reported by: Applause Internal Team

Action Performed:

1. Open any chat
2. Send google.com
3. Hover over the message and click and create thread
4. Verify that thread title is google.com
5. Edit the message to test.com
6. Verify that thread title changes to test.com in LHN

Expected Result:

Verify that thread title changes to test.com in LHN

Actual Result:

Thread title changes to test.com in LHN, When we reload the page.

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

442933936-14927f47-adb4-4f09-962a-605a239374cb.mp4

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021924594297192031032
• Upwork Job ID: 1924594297192031032
• Last Price Increase: 2025-05-26

Issue Owner

Current Issue Owner: @aldo-expensify

[melvin-bot]

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[Burhan-Rashid]

Proposal

Please re-state the problem that we are trying to solve in this issue.

[AU] - LHN - Thread title changes not displayed until we reload the page

What is the root cause of that problem?

The title/ReportName of LHN calculation doesn't take into account the parentReportAction attribute while calculating the reportName/Title, that is why it shows old title instead of the updated one.

App/src/libs/SidebarUtils.ts

Lines 701 to 704 in 074a9fd

	const reportName = getReportName(report, policy, undefined, undefined, invoiceReceiverPolicy);
	result.text = reportName;

What changes do you think we should make in order to solve the problem?

We need to consider the parentReportAction while calculating the reportName here.

App/src/libs/SidebarUtils.ts

Lines 701 to 704 in 074a9fd

	const reportName = getReportName(report, policy, undefined, undefined, invoiceReceiverPolicy);
	result.text = reportName;

const reportName = getReportName(report, policy, parentReportAction, undefined, invoiceReceiverPolicy);

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[ijmalik]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Thread titles do not update dynamically when parent report data changes, requiring a page reload to reflect updates.

What is the root cause of that problem?

App/src/libs/SidebarUtils.ts

Line 702 in eecf578

const reportName = getReportName(report, policy, undefined, undefined, invoiceReceiverPolicy);

App/src/libs/ReportUtils.ts

Lines 4648 to 4654 in 051e86d

	// Check if we can use report name in derived values - only when we have report but no other params
	const canUseDerivedValue = report && policy === undefined && parentReportActionParam === undefined && personalDetails === undefined && invoiceReceiverPolicy === undefined;
	const attributes = reportAttributesParam ?? reportAttributes;
	const derivedNameExists = report && !!attributes?.[report.reportID]?.reportName;
	if (canUseDerivedValue && derivedNameExists) {
	return attributes[report.reportID].reportName;
	}

We call getReportName to fetch the report name. For efficiency with frequent calls, we pass undefined for parentReportAction and personalDetails to use cached values from ONYXKEYS.DERIVED.REPORT_ATTRIBUTES. However, the derived data becomes stale, causing thread titles to remain outdated.

Stale Derived Data:
ONYXKEYS.DERIVED.REPORT_ATTRIBUTES uses cached values when parentReportAction is omitted in getReportName, but the derived data does not update when parent reports change.

Efficiency vs. Freshness Tradeoff:

App/src/libs/actions/OnyxDerived/configs/reportAttributes.ts

Lines 70 to 85 in eecf578

	if (isFullyComputed) {
	// if there are report-related updates, iterate over the updates
	if (updates.length > 0) {
	dataToIterate = prepareReportKeys(updates);
	recentlyUpdated = updates;
	} else if (!!transactionsUpdates || !!transactionViolationsUpdates) {
	let transactionReportIds: string[] = [];
	if (transactionsUpdates) {
	transactionReportIds = Object.values(transactionsUpdates).map((transaction) => `${ONYXKEYS.COLLECTION.REPORT}${transaction?.reportID}`);
	}
	// if transactions are updated, they might not be directly related to the reports yet (e.g. transaction is optimistically created)
	// so we use report keys that were updated before to recompute the reports
	const recentReportKeys = prepareReportKeys([...recentlyUpdated, ...transactionReportIds]);
	dataToIterate = recentReportKeys;
	}
	}

The isFullyComputed flag in reportAttributes.ts optimizes performance by skipping full recomputations but fails to invalidate cache when parent reports update.

Update Detection Gap:

App/src/libs/actions/OnyxDerived/configs/reportAttributes.ts

Line 42 in eecf578

compute: ([reports, preferredLocale, transactionViolations, reportActions, reportNameValuePairs], {currentValue, sourceValues, areAllConnectionsSet}) => {

Our thread title belongs to parent when we make changes in it, parent report is being updated in Onyx. And sourceValues has only parent data so Changes to parent reports (which affect thread titles) do not trigger re-computation of their child thread's derived attributes..

What changes do you think we should make in order to solve the problem?

To minimize efficiency compromise, Replace

App/src/libs/SidebarUtils.ts

Line 702 in eecf578

const reportName = getReportName(report, policy, undefined, undefined, invoiceReceiverPolicy);

with

const reportName = getReportName(
    report,
    policy,
    isChatThread(report) ? parentReportAction : undefined,
    undefined,
    invoiceReceiverPolicy
);

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

What alternative solutions did you explore? (Optional)

61900-video.mp4

[melvin-bot]

@adelekennedy Eep! 4 days overdue now. Issues have feelings too...

[adelekennedy]

I can reproduce and 2e can polish this up