[Due for payment 2025-06-09] [$250] card-Refreshing card's name, showing empty field instead card's name.

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: V9.1.45-18
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: slottwo1w2456@gmail.com
Email or phone of affected tester (no customers): N
Issue reported by: Applause Internal Team
Device used: Redminote note 10s android 13
App Component: Workspace Settings

Action Performed:

1. Go to https://staging.new.expensify.com/home
2. Go to workspace settings - company card
3. Tap add card - american express - american express Business card
4. Assign a card
5. Open the card
6. Tap card's name
7. Refresh the page

Expected Result:

Refreshing card's name, must not show empty field and must show card's name.

Actual Result:

Refreshing card's name, showing empty field instead card's name.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6831802_1747289426882.Screenrecorder-2025-05-15-11-35-49-479.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021924889724426609632
• Upwork Job ID: 1924889724426609632
• Last Price Increase: 2025-05-20
• Automatic offers:
• ikevin127 | Reviewer | 107464799
• nkdengineer | Contributor | 107464800

Issue Owner

Current Issue Owner: @muttmuure

[melvin-bot]

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Refreshing card's name, showing empty field instead card's name.

What is the root cause of that problem?

We're getting the default value for card name in

App/src/pages/workspace/companyCards/WorkspaceCompanyCardEditCardNamePage.tsx

Line 33 in 11385b8

const [customCardNames] = useOnyx(ONYXKEYS.NVP_EXPENSIFY_COMPANY_CARDS_CUSTOM_NAMES);

And it can be undefined at the beginning. And if it's undefined we'll show it empty in the input even though it has value after that

App/src/pages/workspace/companyCards/WorkspaceCompanyCardEditCardNamePage.tsx

Line 91 in 11385b8

defaultValue={defaultValue}

What changes do you think we should make in order to solve the problem?

We should create the util function in CardUtils

let customCardNames: Record<string, string> = {};
Onyx.connect({
    key: ONYXKEYS.NVP_EXPENSIFY_COMPANY_CARDS_CUSTOM_NAMES,
    callback: (value) => {
        customCardNames = value;
    },
});

function getCustomCardName(cardID: string) {
    return customCardNames?.[cardID];
}

Then use it in

App/src/pages/workspace/companyCards/WorkspaceCompanyCardEditCardNamePage.tsx

Line 34 in 11385b8

const defaultValue = customCardNames?.[cardID];

const defaultValue = customCardNames?.[cardID] ?? getCustomCardName(cardID);

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

We can consider the render the input only when customCardNames is loaded

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

@muttmuure Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021924889724426609632

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ikevin127 (External)

[Reaper1x0]

Hi, I'm trying to replicate the issue on your staging but can't add an American Express card because it routes to their service and I don't have a card. But anyway, from the video and description of the problem it seems to be a state management problem. Since the name is loaded when routing from the previous page/screen/state. On refresh, the parameter passed from the route might be missing. Could ensure that the card name is fetched when reloading the page, from whatever parameter is available in the session or card_id.