[Due for payment 2025-06-12] [$250] After removing unvalidated contact, back button reopens same page

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.46-5
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): applausetester+23u230@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.3 / Chrome
App Component: User Settings

Action Performed:

1. Go to staging.new.expensify.com
2. Go to Account > Profile.
3. Click Contact method.
4. Click New contact method.
5. Enter new contact method.
6. Enter magic code.
7. Click 3-dot menu > Remove.
8. Click Yes, continue.
9. Click RHP back button.
10. Click RHP back button again.

Expected Result:

In Step 9. contact methods RHP will close.

Actual Result:

In Step 9, back button on contact methods RHP reopens the same RHP.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021927360758649226069
• Upwork Job ID: 1927360758649226069
• Last Price Increase: 2025-05-27
• Automatic offers:
• nkdengineer | Contributor | 107505021

Issue Owner

Current Issue Owner: @muttmuure

[melvin-bot]

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[mavrickdeveloper]

hi @jponikarchuk , having issues with slack & StackOverflow after changing email
Could you please reinvite me ? sent the forms yesterday but didn't hear back

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

In Step 9, back button on contact methods RHP reopens the same RHP.

What is the root cause of that problem?

We open contact method page with no backTo param

App/src/pages/settings/Profile/ProfilePage.tsx

Line 79 in c4d89f0

pageRoute: ROUTES.SETTINGS_CONTACT_METHODS.route,

So when navigating around this passed backTo param is undefined

App/src/pages/settings/Profile/Contacts/ContactMethodsPage.tsx

Line 96 in c4d89f0

Navigation.navigate(ROUTES.SETTINGS_NEW_CONTACT_METHOD.getRoute(navigateBackTo));

But in NewContactMethodPage we set a fallback to settings profile page

App/src/pages/settings/Profile/Contacts/NewContactMethodPage.tsx

Line 58 in c4d89f0

const navigateBackTo = route?.params?.backTo ?? ROUTES.SETTINGS_PROFILE.getRoute();

So from there, these backTo params are all settings profile page

App/src/pages/settings/Profile/Contacts/NewContactMethodPage.tsx

Line 85 in c4d89f0

Navigation.goBack(ROUTES.SETTINGS_CONTACT_METHOD_DETAILS.getRoute(addSMSDomainIfPhoneNumber(prevPendingContactAction?.contactMethod ?? ''), navigateBackTo, true));

App/src/pages/settings/Profile/Contacts/ContactMethodDetailsPage.tsx

Line 165 in c4d89f0

Navigation.goBack(ROUTES.SETTINGS_CONTACT_METHODS.getRoute(backTo));

And in contact methods page, we use goBack

App/src/pages/settings/Profile/Contacts/ContactMethodsPage.tsx

Line 106 in c4d89f0

onBackButtonPress={() => Navigation.goBack()}

Since in the beginning, we navigate to contact method page with no param, so in contact method details page, when goBack with backTo param, it actually pops the current route (contact method details page) and create a new contact method page for the new route with param. So in step 9 when clicking back button we go back from contact method page with param, to contact method page without param.

And backTo param passed from new contact method page is not applied here because we don't use that in contact methods page

What changes do you think we should make in order to solve the problem?

Fallback route in New Contact Method Page was added in #32065, Not sure why they implemented it that way, but since this page is tied with settings profile page, we can remove this fallback. I tested and the changes work as expected.

Also remove this logic since they are redundant

App/src/pages/settings/Profile/Contacts/NewContactMethodPage.tsx

Lines 127 to 130 in c4d89f0

	if (navigateBackTo === ROUTES.SETTINGS_PROFILE.getRoute()) {
	Navigation.goBack(ROUTES.SETTINGS_CONTACT_METHODS.route);
	return;
	}

Optional, we can add backTo when navigating from settings profile page

App/src/pages/settings/Profile/ProfilePage.tsx

Line 79 in c4d89f0

pageRoute: ROUTES.SETTINGS_CONTACT_METHODS.route,

pageRoute: ROUTES.SETTINGS_CONTACT_METHODS.getRoute(ROUTES.SETTINGS_PROFILE.route)

Optional 2, we should go back using backTo in contact methods page

App/src/pages/settings/Profile/Contacts/ContactMethodsPage.tsx

Line 106 in c4d89f0

onBackButtonPress={() => Navigation.goBack()}

onBackButtonPress={() => Navigation.goBack(navigateBackTo)}

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None, Navigation issue

What alternative solutions did you explore? (Optional)

NA

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[nkdengineer]

I can't reproduce GBR bug at all.

[jponikarchuk]

@mavrickdeveloper sorry, I can't help you with this

[muttmuure]

We can remove the GBR unexpected result

[melvin-bot]

@muttmuure Huh... This is 4 days overdue. Who can take care of this?