[Payment Due 2 June] [$250] Manage my team expenses - The user is redirected to Concierge chat instead of #admins

[vincdargento]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.46-9
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/6136852
Email or phone of affected tester (no customers): testexpensify9+131312903k@gmail.com
Issue reported by: Applause Internal Team
Device used: All platforms
App Component: Other

Action Performed:

1. Open Desktop/Hybrid app or go to https://staging.new.expensify.com/
2. Sign up with a new account without +
3. Click 'Join'
4. On the 'What's your work email?' screen, click Skip
5. On the 'What do you want to do today?' screen, click on Manage my team Expenses
6. Click on '1 - 10 employees' > Continue > QBD (or any account platform)
7. On the 'Take us for a test drive' screen, click Skip

Expected Result:

The user should be redirected to #admins

Actual Result:

The user is redirected to Concierge chat

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

bug.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021925049839628805088
• Upwork Job ID: 1925049839628805088
• Last Price Increase: 2025-05-21
• Automatic offers:
• FitseTLT | Contributor | 107395020

Issue Owner

Current Issue Owner: @RachCHopkins

[melvin-bot]

Triggered auto assignment to @RachCHopkins (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[FitseTLT]

🚨 Edited by proposal-police: This proposal was edited at 2025-05-19 20:16:45 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Manage my team expenses - The user is redirected to Concierge chat instead of #admins

What is the root cause of that problem?

When manage my team is selected we are navigating to the test drive modal here and early returning

App/src/libs/navigateAfterOnboarding.ts

Lines 20 to 23 in 71fd6bf

	if (onboardingPurposeSelected === CONST.ONBOARDING_CHOICES.MANAGE_TEAM) {
	InteractionManager.runAfterInteractions(() => Navigation.navigate(ROUTES.TEST_DRIVE_MODAL_ROOT));
	return;
	}

so the navigate to admins chat code here doesn't run

App/src/libs/navigateAfterOnboarding.ts

Lines 28 to 33 in 71fd6bf

	if (!isSmallScreenWidth) {
	if (onboardingAdminsChatReportID && !shouldPreventOpenAdminRoom) {
	Navigation.navigate(ROUTES.REPORT_WITH_ID.getRoute(onboardingAdminsChatReportID));
	}
	return;
	}

What changes do you think we should make in order to solve the problem?

We should first navigate to the admins chat before navigating to the test drive modal so we can take

App/src/libs/navigateAfterOnboarding.ts

Lines 28 to 33 in 71fd6bf

	if (!isSmallScreenWidth) {
	if (onboardingAdminsChatReportID && !shouldPreventOpenAdminRoom) {
	Navigation.navigate(ROUTES.REPORT_WITH_ID.getRoute(onboardingAdminsChatReportID));
	}
	return;
	}

above

App/src/libs/navigateAfterOnboarding.ts

Lines 20 to 23 in 71fd6bf

	if (onboardingPurposeSelected === CONST.ONBOARDING_CHOICES.MANAGE_TEAM) {
	InteractionManager.runAfterInteractions(() => Navigation.navigate(ROUTES.TEST_DRIVE_MODAL_ROOT));
	return;
	}

// When hasCompletedGuidedSetupFlow is true, OnboardingModalNavigator in AuthScreen is removed from the navigation stack.
    // On small screens, this removal redirects navigation to HOME. Dismissing the modal doesn't work properly,
    // so we need to specifically navigate to the last accessed report.
    if (!isSmallScreenWidth) {
        if (onboardingAdminsChatReportID && !shouldPreventOpenAdminRoom) {
            Navigation.navigate(ROUTES.REPORT_WITH_ID.getRoute(onboardingAdminsChatReportID));
        }
        if (onboardingPurposeSelected !== CONST.ONBOARDING_CHOICES.MANAGE_TEAM) {
            return;
        }
    }

    if (onboardingPurposeSelected === CONST.ONBOARDING_CHOICES.MANAGE_TEAM) {
        InteractionManager.runAfterInteractions(() => Navigation.navigate(ROUTES.TEST_DRIVE_MODAL_ROOT));
        return;
    }

As we will be navigating twice in a row, we can consider using isNavigationReady to be safe.

If we want the same behavior for non-small screen width we can consider navigating to the test drive below after navigating to the last accessed report

Something Like

const navigateAfterOnboarding = (
onboardingPurposeSelected: OnboardingPurpose,
isSmallScreenWidth: boolean,
canUseDefaultRooms: boolean | undefined,
onboardingPolicyID?: string,
activeWorkspaceID?: string,
onboardingAdminsChatReportID?: string,
shouldPreventOpenAdminRoom = false,
) => {
Navigation.dismissModal();

// When hasCompletedGuidedSetupFlow is true, OnboardingModalNavigator in AuthScreen is removed from the navigation stack.
// On small screens, this removal redirects navigation to HOME. Dismissing the modal doesn't work properly,
// so we need to specifically navigate to the last accessed report.
if (!isSmallScreenWidth) {
    if (onboardingAdminsChatReportID && !shouldPreventOpenAdminRoom) {
        Navigation.navigate(ROUTES.REPORT_WITH_ID.getRoute(onboardingAdminsChatReportID));
        if (onboardingPurposeSelected === CONST.ONBOARDING_CHOICES.MANAGE_TEAM) {
            InteractionManager.runAfterInteractions(() => Navigation.navigate(ROUTES.TEST_DRIVE_MODAL_ROOT));
        }
    }
    return;
}

const lastAccessedReport = findLastAccessedReport(!canUseDefaultRooms, shouldOpenOnAdminRoom() && !shouldPreventOpenAdminRoom, activeWorkspaceID);
const lastAccessedReportID = lastAccessedReport?.reportID;
// we don't want to navigate to newly created workspaces after onboarding is completed.
if (!lastAccessedReportID || lastAccessedReport.policyID === onboardingPolicyID || isConciergeChatReport(lastAccessedReport)) {
    if (onboardingPurposeSelected === CONST.ONBOARDING_CHOICES.MANAGE_TEAM) {
        InteractionManager.runAfterInteractions(() => Navigation.navigate(ROUTES.TEST_DRIVE_MODAL_ROOT));
    }
    return;
}

const lastAccessedReportRoute = ROUTES.REPORT_WITH_ID.getRoute(lastAccessedReportID);
Navigation.navigate(lastAccessedReportRoute);

if (onboardingPurposeSelected === CONST.ONBOARDING_CHOICES.MANAGE_TEAM) {
    InteractionManager.runAfterInteractions(() => Navigation.navigate(ROUTES.TEST_DRIVE_MODAL_ROOT));
}

};

but we already early return if the linked policy is the onboarding policy here or the report is concierge chat so we might not need it.
Alternatively we can navigate to the admins chat on dismissing the test drive modal

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

We can add a relevant test in navigateAfterOnboardingTest to assert we also navigate to admins chat before navigating to the test drive modal.

What alternative solutions did you explore? (Optional)

[dmkt9]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Manage my team expenses - The user is redirected to Concierge chat instead of #admins

What is the root cause of that problem?

Because when we select ONBOARDING_CHOICES.MANAGE_TEAM, after onboarding, navigation will only go to ROUTES.TEST_DRIVE_MODAL_ROOT and return:

App/src/libs/navigateAfterOnboarding.ts

Lines 20 to 23 in 9effd91

	if (onboardingPurposeSelected === CONST.ONBOARDING_CHOICES.MANAGE_TEAM) {
	InteractionManager.runAfterInteractions(() => Navigation.navigate(ROUTES.TEST_DRIVE_MODAL_ROOT));
	return;
	}

What changes do you think we should make in order to solve the problem?

Ensure that the Admin chat report is stacked into the navigation just before ROUTES.TEST_DRIVE_MODAL_ROOT:

App/src/libs/navigateAfterOnboarding.ts

Lines 20 to 23 in 9effd91

	if (onboardingPurposeSelected === CONST.ONBOARDING_CHOICES.MANAGE_TEAM) {
	InteractionManager.runAfterInteractions(() => Navigation.navigate(ROUTES.TEST_DRIVE_MODAL_ROOT));
	return;
	}

if (onboardingPurposeSelected === CONST.ONBOARDING_CHOICES.MANAGE_TEAM) {
    InteractionManager.runAfterInteractions(() => {
        if (!isSmallScreenWidth && onboardingAdminsChatReportID && !shouldPreventOpenAdminRoom) {
            Navigation.navigate(ROUTES.REPORT_WITH_ID.getRoute(onboardingAdminsChatReportID));
        }
        Navigation.navigate(ROUTES.TEST_DRIVE_MODAL_ROOT);
    });
    return;
}

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

What alternative solutions did you explore? (Optional)

N/A

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[RachCHopkins]

Repro'd. I assume the tester knows what the correct behaviour is, because I do not.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021925049839628805088

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hungvu193 (External)

[hungvu193]

@FitseTLT 's proposal here looks good to me!

🎀 👀 🎀