[Due for payment 2025-08-13] [$250] Expense - After refreshing page, currency unsaved is shown in BNP page.

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.46-12
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: N/a
Email or phone of affected tester (no customers): slottwo1bi1d@gmail.com
Issue reported by: Applause Internal Team
Device used: Redminote 10s android 13 phone
App Component: Money Requests

Action Performed:

1. Go to https://staging.new.expensify.com/home
2. Tap fab - create expense
3. Select different currency & Enter an amount
4. Refresh the page
5. Note amount not shown but currency which is not saved is shown
6. Tap distance tab
7. Tap manual
8. Now note default currency is shown

Expected Result:

After refreshing page, currency unsaved must not be shown in BNP page.

Actual Result:

After refreshing page, currency unsaved is shown in BNP page.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021928062860802176055
• Upwork Job ID: 1928062860802176055
• Last Price Increase: 2025-07-24
• Automatic offers:
• QichenZhu | Reviewer | 108221302

Issue Owner

Current Issue Owner: @dylanexpensify

[melvin-bot]

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[Burhan-Rashid]

🚨 Edited by proposal-police: This proposal was edited at 2025-07-24 06:59:06 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Expense - After refreshing page, currency unsaved is shown in BNP page.

What is the root cause of that problem?

Whenever we change the currency in IOURequestStepCurrency component, we update the ${ONYXKEYS.COLLECTION.TRANSACTION_DRAFT}${transactionID} > currency.

App/src/pages/iou/request/step/IOURequestStepCurrency.tsx

Lines 58 to 62 in 610a8d4

	Keyboard.dismiss();
	if (pageIndex !== CONST.IOU.PAGE_INDEX.CONFIRM) {
	IOU.setMoneyRequestCurrency(transactionID, option.currencyCode, action === CONST.IOU.ACTION.EDIT);
	}

In the IOURequestStepAmount component, We are using the currency from ONYX draft transactions ${ONYXKEYS.COLLECTION.TRANSACTION_DRAFT}${transactionID}

App/src/pages/iou/request/step/IOURequestStepAmount.tsx

Lines 79 to 80 in 7da8108

	const [personalDetails] = useOnyx(ONYXKEYS.PERSONAL_DETAILS_LIST, {canBeMissing: false});
	const [draftTransaction] = useOnyx(`${ONYXKEYS.COLLECTION.TRANSACTION_DRAFT}${transactionID}`, {canBeMissing: false});

App/src/pages/iou/request/step/IOURequestStepAmount.tsx

Lines 91 to 92 in 7da8108

	const {currency: originalCurrency} = getTransactionDetails(isEditing && !isEmptyObject(draftTransaction) ? draftTransaction : transaction) ?? {currency: CONST.CURRENCY.USD};
	const currency = isValidCurrencyCode(selectedCurrency) ? selectedCurrency : originalCurrency;

As ONYX values are persisted across page refreshes, we see the unsaved currency and not the original currency.

What changes do you think we should make in order to solve the problem?

We can reuse this function initMoneyRequest to reset currency to default currency.

App/src/libs/actions/IOU.ts

Lines 916 to 926 in 76e3fe5

	if (currentIouRequestType === newIouRequestType) {
	// so, we just need to update the reportID, isFromGlobalCreate, created, currency
	Onyx.merge(`${ONYXKEYS.COLLECTION.TRANSACTION_DRAFT}${newTransactionID}`, {
	reportID,
	isFromGlobalCreate,
	created,
	currency,
	transactionID: newTransactionID,
	});
	return;
	}

We can make the following changes then:

 useEffect(() => {
        if (transaction?.amount !== 0) {
            return;
        }
        initMoneyRequest({
            reportID,
            policy,
            isFromGlobalCreate,
            currentIouRequestType: transaction?.iouRequestType,
            newIouRequestType: transaction?.iouRequestType,
        });
        // eslint-disable-next-line
    }, []);

Also we need to update the type here:

App/src/libs/actions/IOU.ts

Line 261 in 76e3fe5

newIouRequestType: IOURequestType;

    newIouRequestType: IOURequestType | undefined;

This is going to reset both the amount and currency on page refresh.
Since we already have the validation that doesn't allow the user to go to the next page if the amount is 0. And we only update the amount in onyx draft transaction once we click on submit button and not on onChange of Amount input. This will ensure that if the user reloads without pressing the next button, the draft transaction amount will be zero and it will reset the currency. And if user has already clicked on the next button then we are sure that the amount > 0 and it has already been saved in onyx. So if a user comes back to this page after a reload on the next page, it won't reset the currency at that time. @QichenZhu

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[dylanexpensify]

reviewing today!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021928062860802176055

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @QichenZhu (External)

[QichenZhu]

@dylanexpensify could you help clarify what "unsaved" means in the title? From what I understand, "saved" means the user clicked the Next button, so there are two cases:

1. If the user clicked Next, the currency and amount should be preserved after a refresh.
2. If the user didn't click Next, the currency and amount should reset to default after a refresh.

Does that sound right?