[$250] Copilot - Workspaces tab opens not here page when opening workspace settings and switch account

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.47-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): applausetester+160510kh@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: iPhone 15 Pro Max / iOS 18.4
App Component: Workspace Settings

Action Performed:

Precondition:

• User A adds User B as copilot.
• Perform the following steps as User B.

1. Launch Expensify app.
2. Go to Workspaces > Workspaces.
3. Tap on any workspace that User A is not a part of.
4. Tap Account from the bottom tab.
5. Tap account switcher.
6. Select User A.
7. After app loads, tap Workspaces.

Expected Result:

App will open Workspaces initial page.

Actual Result:

App opens not here page.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

1.mp4

2.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021925331909710588688
• Upwork Job ID: 1925331909710588688
• Last Price Increase: 2025-05-21
• Automatic offers:
• thelullabyy | Contributor | 107426728

Issue Owner

Current Issue Owner: @

[melvin-bot]

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When open workspace tab after switching copilot, not found page is shown.

What is the root cause of that problem?

When we press the workspace tab, it will open the last workspace page opened.

App/src/components/Navigation/NavigationTabBar/index.tsx

Lines 167 to 183 in 55239b9

	// If there is a workspace navigator route, then we should open the workspace initial screen as it should be "remembered".
	if (lastWorkspacesTabNavigatorRoute.name === NAVIGATORS.WORKSPACE_SPLIT_NAVIGATOR) {
	const params = workspacesTabState?.routes.at(0)?.params as WorkspaceSplitNavigatorParamList[typeof SCREENS.WORKSPACE.INITIAL];
	// Screens of this navigator should always have policyID
	if (params.policyID) {
	const workspaceScreenName = !shouldUseNarrowLayout ? getLastVisitedWorkspaceTabScreen() : SCREENS.WORKSPACE.INITIAL;
	// This action will put settings split under the workspace split to make sure that we can swipe back to settings split.
	navigationRef.dispatch({
	type: CONST.NAVIGATION.ACTION_TYPE.OPEN_WORKSPACE_SPLIT,
	payload: {
	policyID: params.policyID,
	screenName: workspaceScreenName,
	},
	});
	}
	return;
	}

When we switch to a copilot, the account's WS data is different. So, the not found page is shown because the user doesn't have access to it.

What changes do you think we should make in order to solve the problem?

We can check if the WS isn't available anymore, we open the WS initial page.

const [session] = useOnyx(ONYXKEYS.SESSION);
...
if (shouldShowPolicy(getPolicy(params.policyID), false, session?.email)) {
    const workspaceScreenName = !shouldUseNarrowLayout ? getLastVisitedWorkspaceTabScreen() : SCREENS.WORKSPACE.INITIAL;
    // This action will put settings split under the workspace split to make sure that we can swipe back to settings split.
    navigationRef.dispatch({
        type: CONST.NAVIGATION.ACTION_TYPE.OPEN_WORKSPACE_SPLIT,
        payload: {
            policyID: params.policyID,
            screenName: workspaceScreenName,
        },
    });
} else {
    Navigation.navigate(ROUTES.WORKSPACE_HUB_INITIAL);
}

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

[stephanieelliott]

In the web version of the video, you can see in the URL that it is attempting to access the last open workspace, which should not happen when Workspaces is clicked

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021925331909710588688

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @dukenv0307 (External)

[thelullabyy]

🚨 Edited by proposal-police: This proposal was edited at 2025-05-22 09:26:23 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

When open workspace tab after switching copilot, not found page is shown.

What is the root cause of that problem?

When we press the workspace tab, it will open the last workspace page opened that is stored on the session storage

When we switch to another copilot, the previous policyID isn't removed and we still access to that outdated policy

What changes do you think we should make in order to solve the problem?

We need to reset LAST_VISITED_WORKSPACES_TAB_PATH key on the session storage when switching to another copilot.

When executing DISCONNECT_AS_DELEGATE or CONNECT_AS_DELEGATE command, we need to reset LAST_VISITED_WORKSPACES_TAB_PATH to /settings/workspaces by using saveWorkspacesTabPathToSessionStorage

Please note that LAST_VISITED_WORKSPACES_TAB_PATH is outdated when we swithcing to another account. So remove this oudated data is neccesary to prevent other problems can be caused by an outdated value

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

Optionally, but we still write a test that we verify that LAST_VISITED_WORKSPACES_TAB_PATH is reset when we simulating a API call with DISCONNECT_AS_DELEGATE or CONNECT_AS_DELEGATE command

What alternative solutions did you explore? (Optional)

[dukenv0307]

Thanks for all your proposals. I think now we have 2 approaches:

1. Keep the LAST_VISITED_WORKSPACES_TAB_PATH after changing the copilot, and add the logic to check if user A has permission to open the last visited WS or not -> user A can open the last visited WS of user B
2. Reset LAST_VISITED_WORKSPACES_TAB_PATH after changing the copilot, then users A always navigate to initial WS page

I would like to consult more opinions. Keep or reset the last visited WS?

🎀👀🎀 C+ reviewed