[Due for payment 2025-06-11] [$250] Web - Thread- The message with thread replies disappear when deleting it from a parent chat

[nlemma]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.43-7
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: https://github.com/Expensify/Expensify/issues/319505
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Device used:
App Component: Other

Action Performed:

1.Navigate to https://staging.new.expensify.com
2.Navigate to any report
3.Send new message.
4.Click on "Reply in Thread."
5.Send some messages in the thread.
6.Go back to the parent report.
7.Delete the message with thread replies.

Expected Result:

The message does not disappear.

Actual Result:

The message with thread replies disappear for a second when deleting it from a parent chat

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6828718_1747058495410.Recording__3__2_.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021927370428118239621
• Upwork Job ID: 1927370428118239621
• Last Price Increase: 2025-05-27

Issue Owner

Current Issue Owner: @sakluger

[melvin-bot]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[bernhardoj]

🚨 Edited by proposal-police: This proposal was edited at 2025-05-23 04:23:26 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Thread with replies disappears briefly when deleting it.

What is the root cause of that problem?

When we delete an action, it will have a pending action of delete. Thanks to OfflineWithFeedback, a pending delete action will be hidden while online. But we already made an exception for isThreadReportParentAction.

App/src/pages/home/report/PureReportActionItem.tsx

Lines 1406 to 1413 in 409e68e

	<OfflineWithFeedback
	onClose={onClose}
	dismissError={dismissError}
	// eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing
	pendingAction={
	draftMessage !== undefined ? undefined : action.pendingAction ?? (action.isOptimisticAction ? CONST.RED_BRICK_ROAD_PENDING_ACTION.ADD : undefined)
	}
	shouldHideOnDelete={!isThreadReportParentAction}

However, isThreadReportParentAction is only true for the thread parent report action inside the thread.

What changes do you think we should make in order to solve the problem?

Instead of using isThreadReportParentAction, we can use isDeletedParentAction instead.

shouldHideOnDelete={!isDeletedParentAction}

(or we can use isThreadParentMessage)

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

I think we can render PureReportActionItem with an action that has isDeletedParentAction as true and false. If it's true, the action should be visible even when deleted, otherwise, it should be hidden. We need to assign a testID to OfflineWithFeedback children View wrapper.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021927370428118239621

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)