[$250] [Due for payment 2025-06-02] Expense - GBR on the workspace chat does not disappear from LHN after deleting expense report

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.51-0
Reproducible in staging?: Yes
Reproducible in production?: Unable to check, new feature
If this was caught during regression testing, add the test name, ID and link from TestRail: #58020
Email or phone of affected tester (no customers): hndisuhdbishdi@gmail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.4 / Chrome
App Component: Money Requests

Action Performed:

1. Go to staging.new.expensify.com
2. Go to workspace chat.
3. Submit two expenses to the workspace chat.
4. Click on the expense preview to go to expense report.
5. Click More > Delete.
6. Delete the report.

Expected Result:

GBR on the workspace chat will disappear from LHN after deleting the report.

Actual Result:

GBR on the workspace chat does not disappear from LHN after deleting the report.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021930081155633445976
• Upwork Job ID: 1930081155633445976
• Last Price Increase: 2025-06-04

[melvin-bot]

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @marcochavezf (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[twilight2294]

Proposal

Please re-state the problem that we are trying to solve in this issue.

GBR on the workspace chat does not disappear from LHN after deleting expense report

What is the root cause of that problem?

When we delete a report, we do not set the hasOutstandingChildRequest to false of the parent report, this causes the GBR to stay until we open the report again and the OpenReport API sends the correct value of hasOutstandingChildRequest. this is the RCA:

App/src/libs/actions/Report.ts

Lines 4604 to 4606 in 26cd22c

	/** Deletes a report and unreports all transactions on the report along with its reportActions, any linked reports and any linked IOU report actions. */
	function deleteAppReport(reportID: string | undefined) {
	if (!reportID) {

What changes do you think we should make in order to solve the problem?

update the deleteAppReport to optimistically remove hasOutstandingChildRequest and revert the change in failure data as well.

    optimisticData.push({
        onyxMethod: Onyx.METHOD.MERGE,
        key: `${ONYXKEYS.COLLECTION.REPORT}${report?.parentReportID}`,
        value: {hasOutstandingChildRequest: false},
    });

    failureData.push({
        onyxMethod: Onyx.METHOD.MERGE,
        key: `${ONYXKEYS.COLLECTION.REPORT}${report?.parentReportID}`,
        value: {hasOutstandingChildRequest: report?.hasOutstandingChildRequest},
    });

Screen.Recording.2025-05-26.at.2.22.22.PM.mov

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

What alternative solutions did you explore? (Optional)

N/A

[luacmartins]

@allgandalf are you able to take a look at this one?