[$250] Start test drive modal disappear on opening the troubleshoot modal via CTRL+D

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.51-10
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: Exploratory around #62827
Email or phone of affected tester (no customers): kiatest.78+ck5272540@gmail.com
Issue reported by: Applause Internal Team
Device used: Windows 11/Chrome
App Component: Other

Action Performed:

1. Navigate to staging.new.expensify.com
2. Create a new gmail account
3. Open troubleshoot modal by pressing CTRL + D on keyboard
4. Toggle on Force offline
5. Click Skip on What’s your work email?" modal
6. Select any option other than Manage my team's expenses
7. Enter email address in Start test drive modal
8. Open troubleshoot modal by pressing CTRL + D on keyboard

Expected Result:

Start test drive should not disappear when opening the troubleshoot modal via CTRL+D shortcut method

Actual Result:

Start test drive modal disappear on opening the troubleshoot modal via CTRL+D shortcut method

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6843974_1748385375307.Recording__187.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021929545420885711055
• Upwork Job ID: 1929545420885711055
• Last Price Increase: 2025-06-02

Issue Owner

Current Issue Owner: @c3024

[melvin-bot]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[truph01]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The "Start Test Drive" modal disappears when opening the "Troubleshoot" modal using the Ctrl+D shortcut.

What is the root cause of that problem?

• The Test Drive screen is implemented as a modal:
  

  App/src/components/FeatureTrainingModal.tsx

  Line 345 in b2f5d0b

  <Modal

• When the Test Drive modal is visible and the user presses Ctrl+D to open the Troubleshoot (debug) modal, the shortcut triggers this logic:
  

  App/src/libs/actions/TestTool.ts

  Line 24 in b2f5d0b

  close(toggleIsTestToolsModalOpen);

• This logic mistakenly assumes that any existing modal should be closed before toggling the Troubleshoot modal, resulting in the Test Drive modal being dismissed.

What changes do you think we should make in order to solve the problem?

• Modify the logic in here to avoid closing the Test Drive modal when the user is on the /onboarding/test-drive route:

if (Navigation.getActiveRoute() !== '/onboarding/test-drive') { // Can add other routes check here in future
    close(toggleIsTestToolsModalOpen);
} else {
    toggleIsTestToolsModalOpen();
}

• Update the TestToolsModal component to conditionally render only when it's actually open. This ensures proper stacking order (z-index) and prevents it from interfering with other modals:

if (!isTestToolsModalOpen) {
    return null;
}

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

• None

What alternative solutions did you explore? (Optional)

[melvin-bot]

@trjExpensify Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021929545420885711055

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @c3024 (External)