[Due for payment 2025-06-11] [Due for payment 2025-06-09] Onboarding - Endless spinner displayed if tap on Start test drive

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.54
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/6187081
Email or phone of affected tester (no customers): rybkina+052925hoh@gmail.com
Issue reported by: Applause Internal Team
Device used: iPhone 16 Pro Max/ 18.5, Mac/Chrome iPhone 16 Pro Max/ 18.5/Safari mac 15.4.1 Pixel 5/ 14
App Component: Left Hand Navigation (LHN)

Action Performed:

1. Go to staging.new.expensify.com
2. Login with new account > Go to concierge
3. Tap test drive link
4. Enter email in the email field.
5. Click Start test drive.

Expected Result:

Start test drive should be start

Actual Result:

Endless spinner displayed if tap on Start test drive

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @twisterdotcom

[melvin-bot]

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[thelullabyy]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Endless spinner displayed if tap on Start test drive

What is the root cause of that problem?

We throw an error if the entered email is an existing account.

App/src/libs/actions/Onboarding.ts

Lines 20 to 30 in 733010e

	function verifyTestDriveRecipient(email: string) {
	// eslint-disable-next-line rulesdir/no-api-side-effects-method
	return API.makeRequestWithSideEffects(SIDE_EFFECT_REQUEST_COMMANDS.VERIFY_TEST_DRIVE_RECIPIENT, {email}).then((response) => {
	if (!response?.accountExists) {
	// We can invite this user since they do not have an account yet
	return;
	}
	throw new Error(response?.message);
	});
	}

And we don't capture this here, so this page is keeping with the infinite loading state of the button.

App/src/components/TestDrive/Modal/EmployeeTestDriveModal.tsx

Line 51 in 733010e

verifyTestDriveRecipient(bossEmail).then(() => {

What changes do you think we should make in order to solve the problem?

We should capture the catch error of this promise, then we can display the error below the input for the user. We can display another error like This account already exists, please input a new account to test so the user can know why the API fails.

.catch(() => {
    setIsLoading(false);
    setFormError(translate('testDrive.modal.employee.error'));
});

App/src/components/TestDrive/Modal/EmployeeTestDriveModal.tsx

Line 51 in 733010e

verifyTestDriveRecipient(bossEmail).then(() => {

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

NA

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[github-actions]

⚠️ @thelullabyy Thanks for your proposal. Please update it to follow the proposal template, as proposals are only reviewed if they follow that format (note the mandatory sections).

[melvin-bot]

@twisterdotcom Whoops! This issue is 2 days overdue. Let's get this updated quick!

[marcaaron]

Unrelated to the linked Web-E PR. I'm going to confirm that this is not on production.

[marcaaron]

Reproducible in staging?: Yes
Reproducible in production?: No

And no deploy blocker label was applied?

[marcaaron]

Welp, it's on production now...

[fabioh8010]

Commenting for assignment