When Make or track payments is disabled, invoice has pay button in Inbox but not in Reports

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.59-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: #62839
Email or phone of affected tester (no customers): applausetester+040620kh@applause.expensifail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.4 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

• Delay submissions is enabled and set to Manually.
• Add approvals and Make or track payments are disabled.
• Invoice feature is enabled.
• Admin invites member to the workspace.

1. Go to staging.new.expensify.com
2. [Admin] Send an invoice to member.
3. [Member] Go to invoice room.
4. [Member] Note that invoice preview has a pay button.
5. [Member] Go to Reports.
6. [Member] Click Type:Expense filter.
7. [Member] Select Invoice and click Apply.

Expected Result:

Since the invoice has a pay button in the preview in Step 4, the invoice row should show Pay button in Reports in Step 7.

Actual Result:

The invoice row does not show Pay button in Reports, but it shows Pay button in invoice preview.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6851296_1749114075892.20250605_165525.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[thelullabyy]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The invoice row does not show Pay button in Reports, but it shows Pay button in invoice preview.

What is the root cause of that problem?

If the payment is disabled, this function returns false if onlyShowPayElsewhere parameter is false.

App/src/libs/actions/IOU.ts

Lines 9124 to 9131 in a1c004e

	if (policy?.reimbursementChoice === CONST.POLICY.REIMBURSEMENT_CHOICES.REIMBURSEMENT_NO) {
	if (!onlyShowPayElsewhere) {
	return false;
	}
	if (iouReport?.statusNum !== CONST.REPORT.STATUS_NUM.SUBMITTED) {
	return false;
	}
	}

So this condition doesn't match on the search page

App/src/libs/SearchUIUtils.ts

Lines 575 to 580 in a1c004e

	const canBePaid = canIOUBePaid(report, chatReport, policy, allReportTransactions, false, chatReportRNVP, invoiceReceiverPolicy);
	if (canBePaid && !hasOnlyHeldExpenses(report.reportID, allReportTransactions)) {
	return CONST.SEARCH.ACTION_TYPES.PAY;
	}

In the report preview, we show the pay button if canIOUBePaid is true or onlyShowPayElsewhere is true. canIOUBePaid is the result when calling canIOUBePaid with onlyShowPayElsewhere param is false, and onlyShowPayElsewhere is the result when calling canIOUBePaid with onlyShowPayElsewhere param is true. Then the report preview can show the pay button in this case.

App/src/components/ReportActionItem/ReportPreview.tsx

Line 207 in a1c004e

const shouldShowPayButton = isPaidAnimationRunning || canIOUBePaid || onlyShowPayElsewhere;

What changes do you think we should make in order to solve the problem?

We should update the same condition for the search page here

const canBePaid = canIOUBePaid(report, chatReport, policy, allReportTransactions, false, chatReportRNVP, invoiceReceiverPolicy);
const onlyShowPayElsewhere = canIOUBePaid(report, chatReport, policy, allReportTransactions, true, chatReportRNVP, invoiceReceiverPolicy);

if ((canBePaid || onlyShowPayElsewhere) && !hasOnlyHeldExpenses(report.reportID, allReportTransactions)) {
    return CONST.SEARCH.ACTION_TYPES.PAY;
}

App/src/libs/SearchUIUtils.ts

Lines 575 to 580 in a1c004e

	const canBePaid = canIOUBePaid(report, chatReport, policy, allReportTransactions, false, chatReportRNVP, invoiceReceiverPolicy);
	if (canBePaid && !hasOnlyHeldExpenses(report.reportID, allReportTransactions)) {
	return CONST.SEARCH.ACTION_TYPES.PAY;
	}

As I see, the report primary action also has the same bug then we should apply the same fix

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

Add a new data for this scenario and verify that SearchUIUtils test returns the correct action data.

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[joekaufmanexpensify]

This doesn't only happen if payments are enabled on the workspace. We just generally are not showing the option to pay invoices from the reports page. I reported this yesterday actually. I think @hungvu193 and @getusha are going to fix as part of the existing pay button project.

[hungvu193]

Yeah we can handle it as a part of standardize pay button project.

[joekaufmanexpensify]

Sweet, sounds good. Assigning you both then.

[joekaufmanexpensify]

We will work on this once the big pay button PR is merged.