[Due for payment 2025-06-24] [Simplified Actions] [$250] Expense Report - Primary action is again shown in the secondary action for the submitter

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.60-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @c3024
Slack conversation (hyperlinked to channel name): #expensify_bugs

Action Performed:

Prerequisite:
User A is the owner of a workspace and user B is an admin of the workspace.
The workspace has delayed submissions and approvals enabled.

Steps:

1. User A: Create an expense in User A's workspace chat.
2. Click on the expense preview.
3. Click on the "More" dropdown on the header.

Expected Result:

Secondary actions in "More" should not include the primary action "Submit" again.

Actual Result:

Secondary actions in "More" include the primary action "Submit" again.

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Platforms Tested:

On which of our officially supported platforms was this issue tested:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Recording.3164.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021932229200744161185
• Upwork Job ID: 1932229200744161185
• Last Price Increase: 2025-06-10

Issue Owner

Current Issue Owner: @trjExpensify

[melvin-bot]

Triggered auto assignment to @trjExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[izarutskaya]

From @c3024

Proposal

Please re-state the problem that we are trying to solve in this issue.

User sees the primary action in secondary actions again.

What is the root cause of that problem?

We do not filter out the primary action from the secondary actions here.

App/src/components/MoneyReportHeader.tsx

Line 874 in e3d48ad

const applicableSecondaryActions = secondaryActions.map((action) => secondaryActionsImplementation[action]).filter((action) => action?.shouldShow !== false);

What changes do you think we should make in order to solve the problem?

We should filter out the primary action from the secondary actions above.

js
const applicableSecondaryActions = secondaryActions.map((action) => secondaryActionsImplementation[action]).filter((action) => action?.shouldShow !== false && action?.value !== primaryAction);

Apply this to MoneyRequestHeader too.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

Not required but if we use the alternative solution we might consider adding a test for the function for this check.

What alternative solutions did you explore? (Optional)

Pass the primary action to the function getSecondaryReportActions so that it returns the options filtered.

[trjExpensify]

Easily reproducible:

Tagging @luacmartins for eyes on the proposals. I think it's right that we shouldn't show the action twice.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021932229200744161185