[Due for payment 2025-07-04] [$250] Expense - Extra expense with infinite loading appears in Self DM after deleting report in WS

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.65-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): ibellicotest+1029@gmail.com
Issue reported by: Applause Internal Team
Device used: Motorola MotoG60 - Android 12 - Chrome (mWeb - Hybrid App) / Windows 10 - Chrome
App Component: Money Requests

Action Performed:

Prerequisite: Account has at least one workspace created and Self DM.
Prerequisite: Delayed submissions and approvals enabled.

1. Open the staging.new.expensify.com website.
2. Open any workspace chat.
3. Submit a manual expense to it.
4. Navigate to Self DM.
5. Submit another manual expense to it so that now you have 2 expenses on one report.
6. Open the expense created in Self DM.
7. Tap on the report field and select the report of the expense created in workspace chat.
8. Navigate to workspace chat.
9. Submit, approve and pay the expenses on the report.
10. Open the report and tap on "More"
11. Tap on "Cancel Payment"
12. Unapprove the expense.
13. Delete the report.
14. Navigate to Self DM again.
15. Note that both expenses are displayed as unreported on Self DM, and that a third preview, that can´t be opened, is also displayed, showing infinite loading.

Expected Result:

After cancelling payment, unapproving and deleting a report on a workspace chat, expenses on it should be moved to Self DM and no extra expense should be displayed with them.

Actual Result:

When the user cancels a payment, unapprove and deletes a report on a workspace chat, that contains an expense that was moved from Self DM, the expenses on the report, are moved to Self DM again, but now, an extra expense preview, that can´t be opened, appears showing infinite loading.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6857548_1749684457124.Third.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021933269725743755856
• Upwork Job ID: 1933269725743755856
• Last Price Increase: 2025-06-12

Issue Owner

Current Issue Owner: @clarajones-expensify

[melvin-bot]

Triggered auto assignment to @clarajones-expensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Extra expenses with infinite loading in self DM after deleting report where the report is previously paid.

What is the root cause of that problem?

When we delete a report, we optimistically move all money request action to self DM. However, money request action also includes pay action.

App/src/libs/actions/Report.ts

Lines 4748 to 4751 in 04a715b

	Object.values(reportActionsForReport ?? {}).forEach((reportAction) => {
	if (!ReportActionsUtils.isMoneyRequestAction(reportAction)) {
	return;
	}

This causes the extra expense.

What changes do you think we should make in order to solve the problem?

We can return early too if the action is a pay action.

if (!ReportActionsUtils.isMoneyRequestAction(reportAction) || ReportActionsUtils.isPayAction(reportAction)) {
    return;
}

OR

We can return early if the originalMessage.type is not track or create.

const originalMessage = ReportActionsUtils.getOriginalMessage(reportAction);
if (originalMessage?.type !== CONST.IOU.REPORT_ACTION_TYPE.CREATE && originalMessage?.type !== CONST.IOU.REPORT_ACTION_TYPE.TRACK) {
    return;
}

(there is another issue I noticed where the LHN item of the expense thread shows Hidden)

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

We can test deleteAppReport where the report has a pay action and assert that there is no extra expenses.

[clarajones-expensify]

Notes: I was able to reproduce

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021933269725743755856

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @DylanDylann (External)

[clarajones-expensify]

Hi @DylanDylann - would you review the above proposal? Thank you!

[DylanDylann]

@bernhardoj's proposal looks fine to me. Besides checking actionName we also need to verify the originalMessage.type

🎀👀🎀 C+ reviewed