[Due for payment 2025-07-17] [Due for payment 2025-07-15] [$125] "Submitted via delay submissions" system message uses underlined link style instead of non-underlined link style

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.65-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @shawnborton
Slack conversation (hyperlinked to channel name): #expensify_bugs

Action Performed:

1. Go to https://staging.new.expensify.com/
2. Log in
3. Create workspace > Workflows > enable Delay submissions
4. Create expense
5. Wait for the report to be sent automatically

Expected Result:

Don't use underline style for links in system messages

Actual Result:

System message uses underlined link style

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Platforms Tested:

On which of our officially supported platforms was this issue tested:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021934831172945124568
• Upwork Job ID: 1934831172945124568
• Last Price Increase: 2025-06-20

Issue Owner

Current Issue Owner: @RachCHopkins

[melvin-bot]

Triggered auto assignment to @RachCHopkins (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[izarutskaya]

From @dukenv0307

Proposal

Please re-state the problem that we are trying to solve in this issue.

Don't use underline style for links in system messages

What is the root cause of that problem?

We are using AnchorRenderer to render a tag

App/src/components/HTMLEngineProvider/HTMLRenderers/index.ts

Lines 21 to 23 in ef989e6

	const HTMLEngineProviderComponentList: CustomTagRendererRecord = {
	// Standard HTML tag renderers
	a: AnchorRenderer,

And set text decoration here

App/src/components/HTMLEngineProvider/HTMLRenderers/AnchorRenderer.tsx

Lines 136 to 144 in ef989e6

	style={[
	style,
	parentStyle,
	textDecorationLineStyle,
	styles.textUnderlinePositionUnder,
	styles.textDecorationSkipInkNone,
	isChildOfTaskTitle && styles.taskTitleMenuItem,
	styles.dInlineFlex,
	]}

What changes do you think we should make in order to solve the problem?

We can use htmlAttribs to know whether we should use text decoration underline or not

1. We should create a new helper function in en.ts and es.ts files and use it in system messages

    const generateAnchor = (href: string, text: string) => `<a href="${href}" text-decoration-none="true">${text}</a>`;

    automaticallySubmitted: `submitted via ${generateAnchor(CONST.SELECT_WORKFLOWS_HELP_URL, 'delay submissions')}`,

Note: we also need to change other system messages.

2. If we have text-decoration-none, we should set style {textDecoration: 'none'} here

    style={[
        style,
        ...
        htmlAttribs['text-decoration-none'] && {textDecoration: 'none'},
    ]}

App/src/components/HTMLEngineProvider/HTMLRenderers/AnchorRenderer.tsx

Lines 136 to 144 in ef989e6

	style={[
	style,
	parentStyle,
	textDecorationLineStyle,
	styles.textUnderlinePositionUnder,
	styles.textDecorationSkipInkNone,
	isChildOfTaskTitle && styles.taskTitleMenuItem,
	styles.dInlineFlex,
	]}

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None UI bug

What alternative solutions did you explore? (Optional)

Instead of using the text-decoration-none flag, we can consider using htmlAttribs.style

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The delay submission link has underline.

What is the root cause of that problem?

The submitted delay submission message is rendered with the anchor renderer which renders underline by default.

App/src/languages/en.ts

Line 1100 in 04a715b

automaticallySubmitted: `submitted via <a href="${CONST.SELECT_WORKFLOWS_HELP_URL}">delay submissions</a>`,

What changes do you think we should make in order to solve the problem?

We can remove the underline if it's not an ADDCOMMENT action and not inside a task.

action?.actionName !== 'ADDCOMMENT' && !isInConciergeTaskView ? {textDecorationLine: 'none'} : {}

App/src/components/HTMLEngineProvider/HTMLRenderers/AnchorRenderer.tsx

Lines 127 to 145 in 04a715b

	<AnchorForCommentsOnly
	href={attrHref}
	// Unless otherwise specified open all links in
	// a new window. On Desktop this means that we will
	// skip the default Save As... download prompt
	// and defer to whatever browser the user has.
	// eslint-disable-next-line react/jsx-props-no-multi-spaces
	target={htmlAttribs.target || '_blank'}
	rel={htmlAttribs.rel || 'noopener noreferrer'}
	style={[
	style,
	parentStyle,
	textDecorationLineStyle,
	styles.textUnderlinePositionUnder,
	styles.textDecorationSkipInkNone,
	isChildOfTaskTitle && styles.taskTitleMenuItem,
	styles.dInlineFlex,
	]}
	key={key}

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

[RachCHopkins]

Can confirm, I see this behaviour on my own reports.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021934831172945124568