[Due for payment 2025-07-04] [$250] LHN - Report preview is displayed as "Deleted Expense" after splitting a held expense.

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.66-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): ibellicotest+1060@gmail.com
Issue reported by: Applause Internal Team
Device used: Motorola MotoG60 - Android 12 - Chrome (mWeb - Hybrid App) / Windows 10 - Chrome
App Component: Left Hand Navigation (LHN)

Action Performed:

Prerequisite: Account has at least one workspace.

1. Open the Expensify app.
2. Open any workspace chat.
3. Submit a manual expense.
4. Open the just created expense.
5. Tap on "More" and hold the expense.
6. Tap on "More" one more time and select "Split"
7. Save the splits amounts.
8. Navigate to LHN.
9. Note that the report preview, is now displayed as "Deleted Expense" despite the original expense being splitted and not deleted.

Expected Result:

After splitting a held expense, the report preview in LHN should remain displayed with the correct report number.

Actual Result:

After splitting a held expense, the report in preview in LHN is displayed as "Deleted Expense", despite the expense being splitted and not deleted.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021933521870580706202
• Upwork Job ID: 1933521870580706202
• Last Price Increase: 2025-06-13

Issue Owner

Current Issue Owner: @maddylewis

[melvin-bot]

Triggered auto assignment to @maddylewis (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021933521870580706202

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eh2077 (External)

[manideep1428]

@maddylewis @jponikarchuk
Can I do this ? and if I done this successfully will I get $250 ??

[melvin-bot]

📣 @manideep1428! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

After splitting expense with hold, a report in LHN with Deleted expense title is shown.

What is the root cause of that problem?

The Deleted expense report in the LHN is the original transaction thread that is deleted after we split the transaction. Why it shows only if we hold? So, after we hold, the notification preference of the transaction thread is updated to "always".

But it still won't be shown in the LHN yet because it's a one transaction thread.

App/src/libs/ReportUtils.ts

Lines 7908 to 7911 in 8815437

	// If this is a transaction thread associated with a report that only has one transaction, omit it
	if (isOneTransactionThread(report, parentReport, parentReportAction)) {
	return null;
	}

After we do the split, it's not a one transaction thread anymore, so it's shown in the LHN.

What changes do you think we should make in order to solve the problem?

We can optimistically delete the original transaction thread when doing the split.

App/src/libs/actions/IOU.ts

Lines 11684 to 11703 in 8815437

	const firstIOU = iouActions.at(0);
	if (firstIOU) {
	const {updatedReportAction, iouReport} = prepareToCleanUpMoneyRequest(originalTransactionID, firstIOU);
	optimisticData.push({
	onyxMethod: Onyx.METHOD.MERGE,
	key: `${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${iouReport?.reportID}`,
	value: updatedReportAction,
	});
	failureData.push({
	onyxMethod: Onyx.METHOD.MERGE,
	key: `${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${iouReport?.reportID}`,
	value: {
	[firstIOU.reportActionID]: {
	...firstIOU,
	pendingAction: null,
	},
	},
	});
	}

optimisticData.push({
    onyxMethod: Onyx.METHOD.MERGE,
    key: `${ONYXKEYS.COLLECTION.REPORT}${firstIOU?.childReportID}`,
    value: null,
});

and revert it when it fails.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

We can test saveSplitTransactions and assert that the original transaction thread is removed.

[eh2077]

@bernhardoj Thanks for the proposal!

After we do the split, it's not a one transaction thread anymore, so it's shown in the LHN.

Just to be clear, the original IOU action is marked as deleted after splitting.

---

This issue doesn't happen in offline mode, so I think it's a BE issue. Wdyt?

[bernhardoj]

This issue doesn't happen in offline mode, so I think it's a BE issue. Wdyt?

Do you perform all the steps while offline? This issue only happens after you hold the transaction while online because it updates the notification preference to always.