[Payment Due] [$250] Expense - The order of selected workspace and selected report are inconsistent

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.66-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): joiuoijiooiouoiu@gmail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.5 / Chrome
App Component: Money Requests

Action Performed:

1. Go to staging.new.expensify.com
2. Create 4 workspaces and name them A, B, C, D.
3. Go to workspace chat D.
4. Create 4 empty reports and name them A, B, C, D.
5. Go to expense report D.
6. Submit an expense to expense report D.
7. Click More > Change workspace.
8. The order of workspaces is D (selected), A, B, C.
9. Close the RHP.
10. Click Report field.

Expected Result:

The order of reports will follow the same order of workspaces, which is D (selected), A, B, C.

Actual Result:

The order of workspaces is D (selected), A, B, C. The selected workspace appears at the top.
The order of reports is A, B, C, D (selected). The selected report follows alphabetical order.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021938321373515733805
• Upwork Job ID: 1938321373515733805
• Last Price Increase: 2025-06-26
• Automatic offers:
• etCoderDysto | Contributor | 107857006

Issue Owner

Current Issue Owner: @etCoderDysto

[melvin-bot]

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[etCoderDysto]

🚨 Edited by proposal-police: This proposal was edited at 2025-06-13 09:07:06 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

The order of selected workspace and selected report are inconsistent

What is the root cause of that problem?

For workspaces, we use a sortWorkspacesBySelected, custom function that prioritizes the selected item to come on top of alphabetical order.

App/src/hooks/useWorkspaceList.ts

Lines 61 to 64 in cfa3ffc

	const filteredAndSortedUserWorkspaces = useMemo<WorkspaceListItem[]>(
	() =>
	tokenizedSearch(usersWorkspaces, searchTerm, (policy) => [policy.text]).sort((policy1, policy2) =>
	sortWorkspacesBySelected({policyID: policy1.policyID, name: policy1.text}, {policyID: policy2.policyID, name: policy2.text}, selectedPolicyID),

But for expense report use a generic compare function to sort expense reports

App/src/pages/iou/request/step/IOURequestEditReportCommon.tsx

Lines 77 to 80 in cfa3ffc

	return expenseReports
	.sort((a, b) => a?.reportName?.localeCompare(b?.reportName?.toLowerCase() ?? '') ?? 0)
	.filter((report) => !debouncedSearchValue || report?.reportName?.toLowerCase().includes(debouncedSearchValue.toLowerCase()))
	.filter((report): report is NonNullable<typeof report> => report !== undefined)

What changes do you think we should make in order to solve the problem?

We should create a custom sortExpenseReportBySelectedID that do the same things as sortWorkspacesBySelected and use it for reports by passing the function to sort function below

App/src/pages/iou/request/step/IOURequestEditReportCommon.tsx

Line 78 in cfa3ffc

.sort((a, b) => a?.reportName?.localeCompare(b?.reportName?.toLowerCase() ?? '') ?? 0)

function sortExpenseReportBySelectedID (reportA, reportB): number {
        if (selectedReportID) {
            if (reportA.reportID === selectedReportID) {
                return -1;
            }
            if (reportB.reportID === selectedReportID) {
                return 1;
            }
        }
        return reportA?.reportName?.localeCompare(reportB?.reportName?.toLowerCase() ?? '') ?? 0;
    }

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

none

What alternative solutions did you explore? (Optional)

[melvin-bot]

@strepanier03 Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

@strepanier03 Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

@strepanier03 Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

@strepanier03 10 days overdue. Is anyone even seeing these? Hello?

[melvin-bot]

@strepanier03 10 days overdue. I'm getting more depressed than Marvin.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021938321373515733805