[$250] Incorrect role is shown for members in Approver selection list

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.66-5
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @parasharrajat
Slack conversation (hyperlinked to channel name): #expensify_bugs

Action Performed:

First Selection approver for existing rule

1. Go to staging app.
2. Open a workspace where rules are enable.
3. Go to workflows.
4. Click on Add approvals's default rule (on approver part).
5. On the Edit approver workflow page, click approver.

For Add Approver workflow

1. Go to staging app.
2. Open a workspace where rules are enable.
3. Go to workflows.
4. Click on Add approvals sections 's Add Approval workflow button.
5. On the Expenses from page, check members.

Actual Result:

Correct members roles are shown.

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Platforms Tested:

On which of our officially supported platforms was this issue tested:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Recording.3199.mp4

15.06.2025_20.53.35_REC.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021937917870155297729
• Upwork Job ID: 1937917870155297729
• Last Price Increase: 2025-06-25

Issue Owner

Current Issue Owner: @marcaaron

[melvin-bot]

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[izarutskaya]

From @parasharrajat

Proposal

Please re-state the problem that we are trying to solve in this issue.

Incorrect role is shown for members in approver flow.

What is the root cause of that problem?

We do not calculate the correct role for members before showing it. We only check for admin.

1. App/src/pages/workspace/workflows/approvals/WorkspaceWorkflowsApprovalsExpensesFromPage.tsx

   Line 87 in 8815437

   rightElement: isAdmin ? <Badge text={translate('common.admin')} /> : undefined,

2. App/src/pages/workspace/workflows/approvals/WorkspaceWorkflowsApprovalsApproverPage.tsx

   Line 129 in 8815437

   rightElement: isAdmin ? <Badge text={translate('common.admin')} /> : undefined,

What changes do you think we should make in order to solve the problem?

we should calculate the correct role for each member.

1. For WorkspaceWorkflowsApprovalsApproverPage , Update
   

   App/src/pages/workspace/workflows/approvals/WorkspaceWorkflowsApprovalsApproverPage.tsx

   Line 129 in 8815437

   rightElement: isAdmin ? <Badge text={translate('common.admin')} /> : undefined,

                    const isOwner = policy?.owner === employee.email;
                    const isAuditor = employee.role === CONST.POLICY.ROLE.AUDITOR;
                    let roleBadge = null;
                    if (isOwner || isAdmin) {
                        roleBadge = <Badge text={isOwner ? translate('common.owner') : translate('common.admin')} />;
                    } else if (isAuditor) {
                        roleBadge = <Badge text={translate('common.auditor')} />;
                    }

Then we will use `roleBadge` in `rightElement`

2. for WorkspaceWorkflowsApprovalsExpensesFromPage, Update

App/src/pages/workspace/workflows/approvals/WorkspaceWorkflowsApprovalsExpensesFromPage.tsx

Line 111 in 8815437

rightElement: isAdmin ? <Badge text={translate('common.admin')} /> : undefined,

App/src/pages/workspace/workflows/approvals/WorkspaceWorkflowsApprovalsExpensesFromPage.tsx

Line 87 in 8815437

rightElement: isAdmin ? <Badge text={translate('common.admin')} /> : undefined,

  const isOwner = policy?.owner === member.email;
                    const isAuditor = policy?.employeeList?.[member.email]?.role === CONST.POLICY.ROLE.AUDITOR;
                    let roleBadge = null;
                    if (isOwner || isAdmin) {
                        roleBadge = <Badge text={isOwner ? translate('common.owner') : translate('common.admin')} />;
                    } else if (isAuditor) {
                        roleBadge = <Badge text={translate('common.auditor')} />;
                    }


Then we will use `roleBadge` in `rightElement`

3. Update other related pages if any in the flow with the same technique that require showing correct roles.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

Updated related tests.

What alternative solutions did you explore? (Optional)

None.

[melvin-bot]

@adelekennedy Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

@adelekennedy Still overdue 6 days?! Let's take care of this!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021937917870155297729

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eh2077 (External)