[Avatars] Refactor getIcons to Decouple Logic and Resolve Avatar Bugs

[grgia]

Problem

The current implementation of getIcons is overly complex and entangled, making it difficult to trace logic and contributing to a range of recurring avatar-related bugs. This has created both developer overhead and inconsistent user experiences.

Proposed Solution

Refactor getIcons to separate concerns and simplify the underlying logic. This will reduce the surface area for bugs and make future maintenance and enhancements easier.

Plan

Add Tests for Existing Logic

• Write comprehensive test coverage for the current implementation.
• Ensure the existing behavior is documented to prevent regressions during refactor.

Refactor the Function

• Modularize and decouple logic without changing any avatar outputs. (Tests still pass)
• Improve readability, maintainability, and debuggability of the function.

Fix Broken Avatars (IOU)

• Once refactored, identify and resolve any avatar bugs that persist.
• Update tests
• Validate with visual tests & QA verification

[melvin-bot]

This issue has not been updated in over 15 days. @grgia eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[melvin-bot]

@grgia, this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.