[Due for payment 2025-07-04] [$250] Expense - Expense preview disappears in workspace chat after report workspace change fails

[vincdargento]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.68-3
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): sdnsoidjiosjdosd3jo@gmail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.5 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

• Admin invites member to workspace A only.
• Member has another workspace other than workspace A.

1. Go to staging.new.expensify.com
2. [Member] Go to workspace chat of the invited workspace.
3. [Member] Create an expense in the workspace chat.
4. [Member] Click Submit on the expense preview.
5. [Admin] Go to workspace chat with member and open expense report.
6. [Admin] Click More > Hold.
7. [Admin] Enter reason and save it.
8. [Member] Open expense report.
9. [Member] Click More > Change workspace.
10. [Member] Select another workspace.
11. [Member] Dismiss the error message that the report workspace cannot be changed.
12. [Member] Go back to the main workspace chat.

Expected Result:

The expense preview will be displayed in the main workspace chat because changing report workspace fails.

Actual Result:

The expense preview disappears in the main workspace chat when changing report workspace fails.
The expense preview is also not seen in the other workspace chat where the report was intended to change to.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

buf.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021935495089280919000
• Upwork Job ID: 1935495089280919000
• Last Price Increase: 2025-06-19
• Automatic offers:
• nkdengineer | Contributor | 107740356

Issue Owner

Current Issue Owner: @maddylewis

[melvin-bot]

Triggered auto assignment to @maddylewis (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The expense preview disappears in the main workspace chat when changing report workspace fails.
The expense preview is also not seen in the other workspace chat where the report was intended to change to.

What is the root cause of that problem?

The report preview is reverted in the failureData here but oldReportPreviewAction is undefined

App/src/libs/actions/Report.ts

Line 5532 in 53702a2

value: {[oldReportPreviewActionID]: oldReportPreviewAction},

The reason is allReportActions is created with the key is reportID but we get the oldReportPreviewAction with the key is the report action collection key

App/src/libs/actions/Report.ts

Line 5500 in 53702a2

const oldReportPreviewAction = allReportActions?.[`${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${oldWorkspaceChatReportID}`]?.[oldReportPreviewActionID];

App/src/libs/actions/Report.ts

Line 300 in 53702a2

allReportActions[reportID] = actions;

So the report preview is still marked as deleted, and it disappears

What changes do you think we should make in order to solve the problem?

We should get the correct oldReportPreviewAction here

const oldReportPreviewAction = allReportActions?.[oldWorkspaceChatReportID]?.[oldReportPreviewActionID]; 

App/src/libs/actions/Report.ts

Line 5500 in 53702a2

const oldReportPreviewAction = allReportActions?.[`${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${oldWorkspaceChatReportID}`]?.[oldReportPreviewActionID];

And also update the deleted in originalMessage to null in failureData here

value: {[oldReportPreviewActionID]: {
    ...oldReportPreviewAction,
    originalMessage: {
        deleted: null,
    },
    ...(!Array.isArray(oldReportPreviewAction?.message) && {
        message: {
            deleted: null,
        },
    }),
}},

App/src/libs/actions/Report.ts

Line 5532 in 53702a2

value: {[oldReportPreviewActionID]: oldReportPreviewAction},

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

Update changeReportPolicy test and verify that the report preview is updated correct when the API fails

What alternative solutions did you explore? (Optional)

NA

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021935495089280919000

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @dukenv0307 (External)

[dukenv0307]

@nkdengineer's proposal looks good to me, let's fix all places that use allReportActions?.[${ONYXKEYS.COLLECTION.REPORT_ACTIONS... in Report.ts

🎀👀🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @marcaaron, see https://stackoverflow.com/c/expensify/questions/7972 for more details.