[Due for payment 2025-07-17] [$250] Invoice - Add bank account option opens More features page when paying the second invoice

[vincdargento]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.69-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A https://expensify.testrail.io/index.php?/tests/view/6316669
Email or phone of affected tester (no customers): snoidjsodjsodisjdo@gmail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.5 / Chrome
App Component: Money Requests

Action Performed:

Precondition:

• User has received two invoices.

1. Go to staging.new.expensify.com
2. Go to invoice room.
3. Click Pay button on the first invoice preview.
4. Click Pay as a business > Add bank account.
5. Note that Add bank account RHP opens.
6. Close the RHP.
7. On the first invoice, click Pay button > Pay as a business > Pay elsewhere.
8. On the second invoice, click Pay button > Pay as a business > Add bank account.

Expected Result:

Add bank account option will open bank setup RHP when paying the second invoice.

Actual Result:

Add bank account option opens More features page when paying the second invoice.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

bug.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021938013067756720862
• Upwork Job ID: 1938013067756720862
• Last Price Increase: 2025-07-02
• Automatic offers:
• thelullabyy | Contributor | 107896255

Issue Owner

Current Issue Owner: @sonialiap

[melvin-bot]

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[thelullabyy]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Add bank account option opens More features page when paying the second invoice.

What is the root cause of that problem?

The addBankAccountRoute is getting from getBankAccountRoute function.

App/src/hooks/usePaymentOptions.ts

Line 190 in 4c48b2c

onSelected: () => Navigation.navigate(addBankAccountRoute),

App/src/components/ReportActionItem/MoneyRequestReportPreview/MoneyRequestReportPreviewContent.tsx

Line 281 in 4c48b2c

const bankAccountRoute = getBankAccountRoute(chatReport);

App/src/components/ReportActionItem/MoneyRequestReportPreview/MoneyRequestReportPreviewContent.tsx

Line 525 in 4c48b2c

addBankAccountRoute={bankAccountRoute}

For the first invoice, invoiceReceiver isn't a business type, so clicking on this will open SETTINGS_ADD_BANK_ACCOUNT route. After paying the first invoice, the invoiceReceiver is updated to the business type. Then this function returns the workspace invoice page. But the receiver policy doesn't enable the invoice feature, then the more feature page is opened.

App/src/libs/ReportUtils.ts

Lines 1659 to 1670 in 4c48b2c

	function getBankAccountRoute(report: OnyxEntry<Report>): Route {
	if (isPolicyExpenseChat(report)) {
	return ROUTES.BANK_ACCOUNT_WITH_STEP_TO_OPEN.getRoute(report?.policyID, undefined, Navigation.getActiveRoute());
	}
	if (isInvoiceRoom(report) && report?.invoiceReceiver?.type === CONST.REPORT.INVOICE_RECEIVER_TYPE.BUSINESS) {
	return ROUTES.WORKSPACE_INVOICES.getRoute(report?.invoiceReceiver?.policyID);
	}
	return ROUTES.SETTINGS_ADD_BANK_ACCOUNT.route;
	}

What changes do you think we should make in order to solve the problem?

We should only open the workspace invoice page if the receiver policy enables the invoice feature.

if (isInvoiceRoom(report) && report?.invoiceReceiver?.type === CONST.REPORT.INVOICE_RECEIVER_TYPE.BUSINESS) {
    const invoiceReceiverPolicy = allPolicies?.[`${ONYXKEYS.COLLECTION.POLICY}${report?.invoiceReceiver?.policyID}`];
    if (invoiceReceiverPolicy?.areInvoicesEnabled) {
        return ROUTES.WORKSPACE_INVOICES.getRoute(report?.invoiceReceiver?.policyID);
    }
}

App/src/libs/ReportUtils.ts

Lines 1659 to 1670 in 4c48b2c

	function getBankAccountRoute(report: OnyxEntry<Report>): Route {
	if (isPolicyExpenseChat(report)) {
	return ROUTES.BANK_ACCOUNT_WITH_STEP_TO_OPEN.getRoute(report?.policyID, undefined, Navigation.getActiveRoute());
	}
	if (isInvoiceRoom(report) && report?.invoiceReceiver?.type === CONST.REPORT.INVOICE_RECEIVER_TYPE.BUSINESS) {
	return ROUTES.WORKSPACE_INVOICES.getRoute(report?.invoiceReceiver?.policyID);
	}
	return ROUTES.SETTINGS_ADD_BANK_ACCOUNT.route;
	}

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

Add getBankAccountRoute unit test and verify the route is returned correctly.

What alternative solutions did you explore? (Optional)

NA

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

@sonialiap Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

@sonialiap Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021938013067756720862

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)