[$250] Using CMD + K results in long-running query and freezes the app

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.70-1
Reproducible in staging?: Needs Reproduction
Reproducible in production?: Needs Reproduction
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @JmillsExpensify
Slack conversation (hyperlinked to channel name): #Quality

Action Performed:

1. Launch the app
2. Open a DM with someone
3. Press cmd+k

Expected Result:

Search field opens

Actual Result:

Results in continuous loading and app freezes

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Platforms Tested:

On which of our officially supported platforms was this issue tested:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021936494751216936839
• Upwork Job ID: 1936494751216936839
• Last Price Increase: 2025-06-21

Issue Owner

Current Issue Owner: @MonilBhavsar

[melvin-bot]

Current assignee @mallenexpensify is eligible for the Bug assigner, not assigning anyone new.

[MelvinBot]

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

[ZhenjaHorbach]

Can reproduce
And can be a reviewer here !
The most important thing here is to press CMD + K quickly after opening a chat

2025-06-20.22.06.05.mov

[FitseTLT]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Using CMD + K results in long-running query and freezes the app

What is the root cause of that problem?

We are opening search router immediately without waiting for interaction to end here

App/src/libs/Navigation/AppNavigator/AuthScreens.tsx

Lines 391 to 398 in 02e37d7

	const unsubscribeSearchShortcut = KeyboardShortcut.subscribe(
	searchShortcutConfig.shortcutKey,
	() => {
	Session.callFunctionIfActionIsAllowed(() => {
	if (Navigation.isOnboardingFlow()) {
	return;
	}
	toggleSearch();

so when quickly pressing short cut key while interaction from navigation is not resolved sometimes make the app freeze

What changes do you think we should make in order to solve the problem?

We need to open the router modal after interaction

                        InteractionManager.runAfterInteractions(() => {
                            toggleSearch();
                        });

or optionally only apply the runAfterInteractions for opening the modal and directly toggle if it closing

if (isSearchRouterDisplayed) {
                        toggleSearch();
                    } else {
                        InteractionManager.runAfterInteractions(() => {
                            toggleSearch();
                        });
                    }

Additionally, just like we do with opening other shortcut keys we can consider running the callback on modal close Modal.close( after all open modals are closed.
Apply similar fixes for other shortcuts where similar problems occur.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N / A

What alternative solutions did you explore? (Optional)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021936494751216936839