[Due for payment 2025-07-30] [$250] Expense - Missing "Hold" and "Delete expense" option when report has only one expense

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.70-6
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp https://expensify.testrail.io/index.php?/tests/view/6327832
Email or phone of affected tester (no customers): jsidojnsdoisjoid2893@gmail.com
Issue reported by: Applause Internal Team
Device used: Mac 15.5 / Chrome
App Component: Money Requests

Action Performed:

1. Go to staging.new.expensify.com
2. Go to workspace chat.
3. Submit an expense to the workspace chat.
4. Right click on the expense preview on the workspace chat.
5. "Hold" and "Delete expense" options are present in the menu.
6. Submit another expense to the workspace chat.
7. Open the expense report.
8. Click on any expense row.
9. Send a reply to the transaction thread.
10. Click More > Delete > Delete the expense.
11. Go back to the main workspace chat.
12. Right click on the expense preview.

Expected Result:

Since the expense report only has one expense left, "Hold" and "Delete expense" option should be present in the menu.

Actual Result:

After deleting an expense with reply and leaving the report with only one expense, "Hold" and "Delete expense" option are not present in the menu.

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021937667713428517069
• Upwork Job ID: 1937667713428517069
• Last Price Increase: 2025-07-02
• Automatic offers:
• brunovjk | Reviewer | 107961794
• FitseTLT | Contributor | 107961797

Issue Owner

Current Issue Owner: @stephanieelliott

[melvin-bot]

Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[FitseTLT]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Expense - Missing "Hold" and "Delete expense" option when report has only one expense

What is the root cause of that problem?

When finding one transaction thread here we include deleted iou actions with child actions here

App/src/libs/ReportActionsUtils.ts

Lines 1289 to 1290 in bc12ce0

	(isMessageDeleted(action) && action.childVisibleActionCount) ||
	(action.pendingAction === CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE && (isOffline ?? isNetworkOffline)))

so their will not be a one transaction thread here

App/src/pages/home/report/ContextMenu/BaseReportActionContextMenu.tsx

Lines 172 to 174 in bc12ce0

	const transactionThreadReportID = useMemo(
	() => getOneTransactionThreadReportID(childReport, childChatReport, paginatedReportActions ?? [], isOffline),
	[paginatedReportActions, isOffline, childReport, childChatReport],

so the only iou action will not be set here

App/src/pages/home/report/ContextMenu/BaseReportActionContextMenu.tsx

Line 192 in bc12ce0

const moneyRequestAction = transactionThreadReportID ? requestParentReportAction : parentReportAction;

What changes do you think we should make in order to solve the problem?

We should avoid adding deleted iou actions so make this condition

App/src/libs/ReportActionsUtils.ts

Line 1289 in bc12ce0

(isMessageDeleted(action) && action.childVisibleActionCount) ||

optional and control via a param shouldIncludeDeletedIOU on the function then pass the param as false where needed like here

App/src/pages/home/report/ContextMenu/BaseReportActionContextMenu.tsx

Lines 172 to 174 in bc12ce0

	const transactionThreadReportID = useMemo(
	() => getOneTransactionThreadReportID(childReport, childChatReport, paginatedReportActions ?? [], isOffline),
	[paginatedReportActions, isOffline, childReport, childChatReport],

and other places needed

Alternatively, we can remove the condition for all cases because it is an old code which was written when we used to show deleted transaction threads with non-zero child actions.

App/src/libs/ReportActionsUtils.ts

Line 1289 in bc12ce0

(isMessageDeleted(action) && action.childVisibleActionCount) ||

The other option we can follow is to provide a filtered actions list by filtering out the deleted iou actions similar to the getFilteredReportActionsForReportView filter we use here

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

If needed we can test getOneTransactionThreadReportID that it does return the one transaction thread even if there are deleted iou actions in the actions list param we pass.

What alternative solutions did you explore? (Optional)

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021937667713428517069

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @brunovjk (External)

[brunovjk]

It's on my list, I'll review it ASAP.

[melvin-bot]

@brunovjk Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[brunovjk]

Not overdue, reviewing soon