[Due for payment 2025-07-15] [$250] iOS - WS - A warning with previous approver appears briefly when removing an approver

[jponikarchuk]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.72.0
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: Exploratory
Email or phone of affected tester (no customers): n/a
Issue reported by: Applause Internal Team
Device used: iPhone 13 iOS 18.5 Hybrid
App Component: Workspace Settings

Action Performed:

1. Open the app
2. Create a workspace
3. Invite two members
4. Enable workflows and approvals
5. Add one of the recently added members as the approver
6. As the workspace admin, navigate to members
7. Click on the member that is the approver
8. Click on Remove from workspace and Remove
9. Verify that you see the message: "${memberName} is an approver in this workspace. When you unshare this workspace with them, we’ll replace them in the approval workflow with the workspace owner, ${ownerName}"
10. Navigate to Workflows
11. Add another member as the approver
12. Navigate to members
13. Click on the member that is the approver
14. Click on Remove from workspace and Remove

Expected Result:

When removing the approver for the second time, the warning message is correct.

Actual Result:

When removing an approver for the second time, a warning appears briefly with the previous approver

Workaround:

Unknown

Platforms:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021939714905886884027
• Upwork Job ID: 1939714905886884027
• Last Price Increase: 2025-06-30
• Automatic offers:
• Krishna2323 | Contributor | 107913020

Issue Owner

Current Issue Owner: @clarajones-expensify

[melvin-bot]

Triggered auto assignment to @clarajones-expensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[Krishna2323]

Proposal

Please re-state the problem that we are trying to solve in this issue.

iOS - WS - A warning with previous approver appears briefly when removing an approver

What is the root cause of that problem?

• removeMemberAndCloseModal is called after the onyx update and this causes the useEffect to run even before the modal is closed and the modal stays in a separate native window which can cause this issue when multiple modals are not closed properly:
  

  App/src/pages/workspace/members/WorkspaceMemberDetailsPage.tsx

  Lines 166 to 218 in a8bf844

  	useEffect(() => {
  	if (!prevMember || prevMember?.pendingAction === CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE || member?.pendingAction !== CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE) {
  	return;
  	}
  	Navigation.goBack();
  	}, [member, prevMember]);
  	const askForConfirmationToRemove = () => {
  	setIsRemoveMemberConfirmModalVisible(true);
  	};
  	// Function to remove a member and close the modal
  	const removeMemberAndCloseModal = useCallback(() => {
  	removeMembers([accountID], policyID);
  	const previousEmployeesCount = Object.keys(policy?.employeeList ?? {}).length;
  	const remainingEmployeeCount = previousEmployeesCount - 1;
  	if (remainingEmployeeCount === 1 && policy?.preventSelfApproval) {
  	// We can't let the "Prevent Self Approvals" enabled if there's only one workspace user
  	setPolicyPreventSelfApproval(route.params.policyID, false);
  	}
  	setIsRemoveMemberConfirmModalVisible(false);
  	}, [accountID, policy?.employeeList, policy?.preventSelfApproval, policyID, route.params.policyID]);
  	const removeUser = useCallback(() => {
  	const ownerEmail = ownerDetails?.login;
  	const removedApprover = personalDetails?.[accountID];
  	// If the user is not an approver, proceed with member removal
  	if (!isApproverUserAction(policy, accountID) || !removedApprover?.login || !ownerEmail) {
  	removeMemberAndCloseModal();
  	return;
  	}
  	// Update approval workflows after approver removal
  	const updatedWorkflows = updateWorkflowDataOnApproverRemoval({
  	approvalWorkflows,
  	removedApprover,
  	ownerDetails,
  	});
  	updatedWorkflows.forEach((workflow) => {
  	if (workflow?.removeApprovalWorkflow) {
  	const {removeApprovalWorkflow, ...updatedWorkflow} = workflow;
  	removeApprovalWorkflowAction(policyID, updatedWorkflow);
  	} else {
  	updateApprovalWorkflow(policyID, workflow, [], []);
  	}
  	});
  	// Remove the member and close the modal
  	removeMemberAndCloseModal();
  	}, [accountID, approvalWorkflows, ownerDetails, personalDetails, policy, policyID, removeMemberAndCloseModal]);

What changes do you think we should make in order to solve the problem?

• We can wrap Navigation.goBack() in navigateAfterInteraction which will allow the modal to close properly without navigating until the modal is closed.

    useEffect(() => {
        if (!prevMember || prevMember?.pendingAction === CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE || member?.pendingAction !== CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE) {
            return;
        }

        navigateAfterInteraction(() => Navigation.goBack());
    }, [member, prevMember]);

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

What alternative solutions did you explore? (Optional)

In removeUser and removeMemberAndCloseModal we can call setIsRemoveMemberConfirmModalVisible(false) before updating the onyx values and then wrap the util functions inside InteractionManager.runAfterInteractions.

What alternative solutions did you explore? (Optional 2)

We can also use useBeforeRemove to close the modal before navigating.

Result

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021939714905886884027

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @c3024 (External)

[c3024]

iOS appears to exhibit this behaviour:

App/src/libs/Navigation/navigateAfterInteraction/index.ios.ts

Lines 5 to 6 in 3bdf375

	* On iOS, the navigation transition can sometimes break other animations, such as the closing modal.
	* In this case we need to wait for the animation to be complete before executing the navigation

@Krishna2323’s proposal to navigate after the animation completes looks good to me.

🎀 👀 🎀

[melvin-bot]

Triggered auto assignment to @grgia, see https://stackoverflow.com/c/expensify/questions/7972 for more details.