[Due for payment 2025-07-18] [$250] If a searched user is not in the suggested list, a 'No results found' message should be displayed in From/To filter options

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

---

Version Number: 9.1.73-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @Eskalifer1
Slack conversation (hyperlinked to channel name): #Open source

Action Performed:

1. Open Reports
2. Select Filters
3. In the From (or To) tab, search for a user who is not listed

Expected Result:

If a searched user is not in the suggested list, a 'No results found' message should be displayed.

Actual Result:

Search results are displayed

Workaround:

Unknown

Platforms:

Select the officially supported platforms where the issue was reproduced:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Platforms Tested:

On which of our officially supported platforms was this issue tested:

• Android: App
• Android: mWeb Chrome
• iOS: App
• iOS: mWeb Safari
• iOS: mWeb Chrome
• Windows: Chrome
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Recording.1358.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021940471671938507768
• Upwork Job ID: 1940471671938507768
• Last Price Increase: 2025-07-02

Issue Owner

Current Issue Owner: @CortneyOfstad

[melvin-bot]

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[Eskalifer1]

Proposal

Please re-state the problem that we are trying to solve in this issue.

If a searched user is not in the suggested list, a 'No results found' message should be displayed in From/To filter options

What is the root cause of that problem?

The reason for this behavior is the call to this useEffect:

App/src/components/Search/SearchFiltersParticipantsSelector.tsx

Lines 159 to 161 in a8246a8

	useEffect(() => {
	searchInServer(debouncedSearchTerm.trim());
	}, [debouncedSearchTerm]);

which makes a request and invites users

What changes do you think we should make in order to solve the problem?

To prevent the request from being executed, we need to remove this useEffect

Additionally, if we want to display:
“No results found matching {string}”

We can replace the string:

App/src/components/Search/SearchFiltersParticipantsSelector.tsx

Line 117 in a8246a8

const message = noResultsFound ? translate('common.noResultsFound') : undefined;

For:

const message = noResultsFound ? translate('common.noResultsFoundMatching', {searchString: cleanSearchTerm}) : undefined;

Additionally we can pass canInvite to false if needed:

const chatOptions = useMemo(() => {
        return filterAndOrderOptions(defaultOptions, cleanSearchTerm, {
            selectedOptions,
            excludeLogins: CONST.EXPENSIFY_EMAILS_OBJECT,
            maxRecentReportsToShow: CONST.IOU.MAX_RECENT_REPORTS_TO_SHOW,
            canInviteUser: false,
        });
    }, [defaultOptions, cleanSearchTerm, selectedOptions]);

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021940471671938507768

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @dukenv0307 (External)

[CortneyOfstad]

Hey @dukenv0307! There is a proposal here for you to review when you have a chance!

Also, I will be heading OoO this afternoon (July 2-7) so if there is any action needed from a BZ perspective, please reach out in Slack — otherwise I will review as soon as I am back in office on Tuesday. Thanks!

[Burhan-Rashid]

Proposal

Please re-state the problem that we are trying to solve in this issue.

If a searched user is not in the suggested list, a 'No results found' message should be displayed in From/To filter options

What is the root cause of that problem?

App/src/components/Search/SearchFiltersParticipantsSelector.tsx

Lines 159 to 161 in 9e3b5bd

	useEffect(() => {
	searchInServer(debouncedSearchTerm.trim());
	}, [debouncedSearchTerm]);

We are using SearchInServer function to search the user in the server whenever the search term changes. If the searched user is not already present in the suggestions list, we fetch the user from the server and show it on the UI.

What changes do you think we should make in order to solve the problem?

We should add an additional optional prop canUseServerSearch to the component here

type SearchFiltersParticipantsSelectorProps = {
    initialAccountIDs: string[];
    onFiltersUpdate: (accountIDs: string[]) => void;
    canUseServerSearch?: boolean;
};

function SearchFiltersParticipantsSelector({initialAccountIDs, onFiltersUpdate, canUseServerSearch = true}: SearchFiltersParticipantsSelectorProps) {

and call the searchInServer function in useEffect only when the canUseServerSearch prop is true here.

  useEffect(() => {
        if (!canUseServerSearch) {
            return;
        }
        searchInServer(debouncedSearchTerm.trim());
    }, [debouncedSearchTerm, canUseServerSearch]);

And we can set its default value of the canUseServerSearch prop as true, so that wherever we are using this component the functionality should remain the same as before. Only we need to pass this prop as false here as we don't want serverSearch in AdvancedFilters according to the OP.

 <SearchFiltersParticipantsSelector
                    canUseServerSearch={false}

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[dukenv0307]

Reviewing...